Re: [11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-10 Thread Roger Riggs
Hi, On 5/9/2018 6:49 PM, Vincent Ryan wrote: Thanks Roger for your comments. The main motivator for this class is to provide a basic hex. encoder/decoder for smaller amounts of binary data and to provide a hexdump encoder for larger amounts of binary data, while recognising the need to cater

Re: [11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-10 Thread Vincent Ryan
> On 10 May 2018, at 01:08, Weijun Wang wrote: > > > >> On May 10, 2018, at 6:49 AM, Vincent Ryan wrote: >> >>> >>> - As Max observes, being able to supply the delimiters might be a good >>> addition. (I'm thinking IP addresses too). >>

Re: [11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-09 Thread Weijun Wang
> On May 10, 2018, at 6:49 AM, Vincent Ryan wrote: > >> >> - As Max observes, being able to supply the delimiters might be a good >> addition. (I'm thinking IP addresses too). > > Sure. Add another toHexString method that takes a delimiter character? Good idea.

Re: [11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-09 Thread Vincent Ryan
Thanks for your comments Max. > On 9 May 2018, at 03:34, Weijun Wang wrote: > > Nice tool. > > However, I am not sure how toFormattedHexString() and toPrintableString() are > useful, seems only for providing a customizable dump format which is, > actually, not very

Re: [11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-09 Thread Vincent Ryan
Thanks Roger for your comments. The main motivator for this class is to provide a basic hex. encoder/decoder for smaller amounts of binary data and to provide a hexdump encoder for larger amounts of binary data, while recognising the need to cater for custom formats too. The class does not

Re: [11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-09 Thread Roger Riggs
Hi Vinnie, On the API and spec, a few comments:  - Expanding the printable string from ASCII to ISO-8859-1 would make it a bit more useful in more cases.    That might suggest using the Charset converter to do the work (less optimized but more functional). - There is no API support for

Re: [11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-08 Thread Weijun Wang
Nice tool. However, I am not sure how toFormattedHexString() and toPrintableString() are useful, seems only for providing a customizable dump format which is, actually, not very customizable. For me, toHexString and fromHexString are of course the most useful methods. As for dump, I can only

[11] RFR: 8170769 Provide a simple hexdump facility for binary data

2018-05-03 Thread Vincent Ryan
Hello, Please review this proposal for a new API to conveniently generate and display binary data using hex string representation. It supports both bulk and stream operations and it can also generate the well-known hexdump format [1]. Thanks Bug: