Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-19 Thread Alex Kashchenko
Hi, On 09/18/2018 07:22 PM, Erik Joelsson wrote: Looks good to me. I guess it's hard to prove that the output is now stable, but time will tell. /Erik On 2018-09-18 10:41, Naoto Sato wrote: Hello, Please review the fix to the following issue:

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-19 Thread Magnus Ihse Bursie
On 2018-09-18 19:41, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8209880/webrev.00/ Looks good. Thank you for fixing this! /Magnus The

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-18 Thread Roger Riggs
Hi Naoto, The elimination of duplicates and stable iteration should help. +1 Roger On 9/18/18 1:41 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at:

Re: [12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-18 Thread Erik Joelsson
Looks good to me. I guess it's hard to prove that the output is now stable, but time will tell. /Erik On 2018-09-18 10:41, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at:

[12] RFR: 8209880: tzdb.dat is not reproducibly built

2018-09-18 Thread Naoto Sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8209880 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8209880/webrev.00/ The fix is to remove the use of HashSet/Map which is not guaranteed to preserve the same order on