Looks good. -B
On 11/6/19 6:11 PM, naoto.s...@oracle.com wrote:
Here is the updated webrev:
https://cr.openjdk.java.net/~naoto/8232871/webrev.01/
Hi Brent,
Thank you for the review! Please see my comments below.
On 11/6/19 3:27 PM, Brent Christian wrote:
Hi, Naoto
Looks pretty good. I have a few comments:
--
src/java.base/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
572 map =
Hi, Naoto
Looks pretty good. I have a few comments:
--
src/java.base/macosx/classes/sun/util/locale/provider/HostLocaleProviderAdapterImpl.java
572 map = new HashMap<>();
FWIW, I believe the HashMap could be pre-sized using 'names.length'.
--
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8232871
The proposed changeset is located at:
https://cr.openjdk.java.net/~naoto/8232871/webrev.00/
Implementation for getting calendar display names was missing in macOS's
host adapter.
Naoto
