+1
On 2/11/20 6:12 PM, Joe Wang wrote:
+1. That's nicer.
-Joe
On 2/11/20 10:17 AM, naoto.s...@oracle.com wrote:
Hi,
I modified the proposed changeset. Removed the hard coded 3-letter id
compatibility mappings (oldMappings) from CLDRConverter.java.
Instead, using public ZoneId.SHORT_IDS
+1. That's nicer.
-Joe
On 2/11/20 10:17 AM, naoto.s...@oracle.com wrote:
Hi,
I modified the proposed changeset. Removed the hard coded 3-letter id
compatibility mappings (oldMappings) from CLDRConverter.java. Instead,
using public ZoneId.SHORT_IDS that contain the same set of mappings
Hi,
I modified the proposed changeset. Removed the hard coded 3-letter id
compatibility mappings (oldMappings) from CLDRConverter.java. Instead,
using public ZoneId.SHORT_IDS that contain the same set of mappings
(wasn't aware it was defined in the spec!)
Here is the updated webrev:
Drafted a CSR:
https://bugs.openjdk.java.net/browse/JDK-8238809
Appreciate the review for this as well.
Naoto
On 2/10/20 8:52 AM, naoto.s...@oracle.com wrote:
Good point. I will file a CSR for the behavioral changes.
Naoto
On 2/7/20 6:00 PM, Joe Wang wrote:
Hi Naoto,
I see the existing
Good point. I will file a CSR for the behavioral changes.
Naoto
On 2/7/20 6:00 PM, Joe Wang wrote:
Hi Naoto,
I see the existing tests were changed, e.g. the abbreviation / short
timezone name, the result of calling getDisplayName. Would you need a
CSR to discuss/document the potential
Hi Naoto,
I see the existing tests were changed, e.g. the abbreviation / short
timezone name, the result of calling getDisplayName. Would you need a
CSR to discuss/document the potential incompatibility?
Best,
Joe
On 2/7/20 1:44 PM, naoto.s...@oracle.com wrote:
Hello,
Please review the
Hello,
Please review the fix to the following issues:
https://bugs.openjdk.java.net/browse/JDK-8234347
https://bugs.openjdk.java.net/browse/JDK-8236548
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8234347.8236548/webrev.00/
This changeset includes the following
