Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you, Vyom Regards, Chris > On 23 Apr 2020, at 4:35 PM, Vyom Tiwari wrote: > > Hi Chris, > change looks good to me. > Vyom > > On Wed, Apr 22, 2020 at 12:59 PM Chris Yin > wrote: > Hello > > Please review following change for enhancement to >

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you, Daniel. Pushed Regards, Chris > On 23 Apr 2020, at 4:11 PM, Daniel Fuchs wrote: > > On 23/04/2020 01:39, Aleks Efimov wrote: >> Hi Chris, >> The changes look good to me. >> Thank you for extending the LDAP test server functionality. > > +1 > > Reviewed. > > best regards, > > --

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Hi Chris, change looks good to me. Vyom On Wed, Apr 22, 2020 at 12:59 PM Chris Yin wrote: > Hello > > Please review following change for enhancement to > com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks > > Bug: https://bugs.openjdk.java.net/browse/JDK-8243138 > Webrev:

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

On 23/04/2020 01:39, Aleks Efimov wrote: Hi Chris, The changes look good to me. Thank you for extending the LDAP test server functionality. +1 Reviewed. best regards, -- daniel

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Thank you for reviewing, Aleksei Regards, Chris > On 23 Apr 2020, at 8:39 AM, Aleks Efimov wrote: > > Hi Chris, > > The changes look good to me. > Thank you for extending the LDAP test server functionality. > > With Best Regards, > Aleksei > > On 22/04/2020 08:27, Chris Yin wrote: >> Hello

Re: [15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Hi Chris, The changes look good to me. Thank you for extending the LDAP test server functionality. With Best Regards, Aleksei On 22/04/2020 08:27, Chris Yin wrote: Hello Please review following change for enhancement to com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks Bug:

[15] RFR: 8243138: Enhance BaseLdapServer to support starttls extended request

Hello Please review following change for enhancement to com/sun/jndi/ldap/lib/BaseLdapServer.java, thanks Bug: https://bugs.openjdk.java.net/browse/JDK-8243138 Webrev: http://cr.openjdk.java.net/~xyin/8243138/webrev.00/ There is requirement to test starttls extended op against dummy ldap