Re: [8] Request for Review: Fix doclint accessibility issues in java.io

2013-07-18 Thread Chris Hegarty
On 18/07/2013 06:12, Joe Darcy wrote: Looks fine. +1. -Chris. Thanks, -Joe On 07/17/2013 04:19 PM, Jason Uh wrote: Thanks, Mike. I'll add that before I push. On 7/17/13 4:00 PM, Mike Duigou wrote: Looks good to me. You could add {@code} around true in ObjectStreamField Mike On Jul

[8] Request for Review: Fix doclint accessibility issues in java.io

2013-07-17 Thread Jason Uh
Hi Joe, Could I please get a review of this change? This changeset fixes doclint issues in java.io. Webrev: http://cr.openjdk.java.net/~juh/8020426/webrev.02/ Changes have been checked with specdiff. Thanks, Jason

Re: [8] Request for Review: Fix doclint accessibility issues in java.io

2013-07-17 Thread Mike Duigou
Looks good to me. You could add {@code} around true in ObjectStreamField Mike On Jul 17 2013, at 15:40 , Jason Uh wrote: Hi Joe, Could I please get a review of this change? This changeset fixes doclint issues in java.io. Webrev: http://cr.openjdk.java.net/~juh/8020426/webrev.02/

Re: [8] Request for Review: Fix doclint accessibility issues in java.io

2013-07-17 Thread Jason Uh
Thanks, Mike. I'll add that before I push. On 7/17/13 4:00 PM, Mike Duigou wrote: Looks good to me. You could add {@code} around true in ObjectStreamField Mike On Jul 17 2013, at 15:40 , Jason Uh wrote: Hi Joe, Could I please get a review of this change? This changeset fixes doclint

Re: [8] Request for Review: Fix doclint accessibility issues in java.io

2013-07-17 Thread Joe Darcy
Looks fine. Thanks, -Joe On 07/17/2013 04:19 PM, Jason Uh wrote: Thanks, Mike. I'll add that before I push. On 7/17/13 4:00 PM, Mike Duigou wrote: Looks good to me. You could add {@code} around true in ObjectStreamField Mike On Jul 17 2013, at 15:40 , Jason Uh wrote: Hi Joe, Could I