Re: [8u] 8205432: Replace the placeholder Japanese era name

Thanks, Andrew. :) On 4/9/19, 10:27 AM, "Andrew John Hughes" wrote: On 09/04/2019 18:18, Hohensee, Paul wrote: > I meant the current webrev > > https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.02/ > > is fine. Just backport what's in tip and fix whatever's

Re: [8u] 8205432: Replace the placeholder Japanese era name

On 09/04/2019 18:18, Hohensee, Paul wrote: > I meant the current webrev > > https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.02/ > > is fine. Just backport what's in tip and fix whatever's wrong later as > another backport or backports. > > Paul Thanks. I've pushed based on the

Re: [8u] 8205432: Replace the placeholder Japanese era name

I meant the current webrev https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.02/ is fine. Just backport what's in tip and fix whatever's wrong later as another backport or backports. Paul On 4/9/19, 8:56 AM, "core-libs-dev on behalf of Hohensee, Paul" wrote: +1.

Re: [8u] 8205432: Replace the placeholder Japanese era name

+1. Paul On 4/8/19, 8:28 PM, "core-libs-dev on behalf of Andrew John Hughes" wrote: On 08/04/2019 09:25, Deepak Kejriwal wrote: > Hi Andrew, > > Thanks for working on this. Please find below few minor comments:- > > 1>. For

Re: RFR: [8u] 8205432: Replace the placeholder Japanese era name

On 4/9/19 4:26 AM, Andrew John Hughes wrote: > I've fixed this too, but note that this comes from the original patch in > 11 and up. So it actually needs fixing there too. > > Revised webrev: > https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.02/ OK. -- Andrew Haley Java Platform

Re: RFR: [8u] 8205432: Replace the placeholder Japanese era name

On 08/04/2019 09:25, Deepak Kejriwal wrote: > Hi Andrew, > > Thanks for working on this. Please find below few minor comments:- > > 1>. For "src/share/classes/java/util/JapaneseImperialCalendar.java" and > "src/share/classes/sun/util/calendar/Era.java" please changes the date time > format to

Re: RFR: [8u] 8205432: Replace the placeholder Japanese era name

On 4/8/19 5:40 AM, Andrew John Hughes wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8205432 > Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.01/ OK, thanks. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. EAC8 43EB D3EF DB98

RE: RFR: [8u] 8205432: Replace the placeholder Japanese era name

10 AM To: jdk8u-...@openjdk.java.net; core-libs-dev@openjdk.java.net Subject: RFR: [8u] 8205432: Replace the placeholder Japanese era name Bug: https://bugs.openjdk.java.net/browse/JDK-8205432 Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.01/ This is a relatively clean backpor

RFR: [8u] 8205432: Replace the placeholder Japanese era name

Bug: https://bugs.openjdk.java.net/browse/JDK-8205432 Webrev: https://cr.openjdk.java.net/~andrew/openjdk8/8205432/webrev.01/ This is a relatively clean backport, with a few exceptions, mostly due to unneeded copyright changes or moved files: * 8u has FormatData_ja.java and