Re: [9] RFR: 8168921: Inconsistent Annotation.toString()

2016-11-02 Thread Joseph D. Darcy
Looks good Ivan; thanks, -Joe On 11/2/2016 8:58 AM, Ivan Gerasimov wrote: Thank you Joe for review! On 31.10.2016 20:11, joe darcy wrote: Hi Ivan, The code change in src look fine, but please update the existing test test/java/lang/annotation/AnnotationToStringTest.java rather than in

Re: [9] RFR: 8168921: Inconsistent Annotation.toString()

2016-11-02 Thread Claes Redestad
On 2016-11-02 16:58, Ivan Gerasimov wrote: Thank you Joe for review! On 31.10.2016 20:11, joe darcy wrote: Hi Ivan, The code change in src look fine, but please update the existing test test/java/lang/annotation/AnnotationToStringTest.java rather than introducing a new test file. Y

Re: [9] RFR: 8168921: Inconsistent Annotation.toString()

2016-11-02 Thread Ivan Gerasimov
Thank you Joe for review! On 31.10.2016 20:11, joe darcy wrote: Hi Ivan, The code change in src look fine, but please update the existing test test/java/lang/annotation/AnnotationToStringTest.java rather than introducing a new test file. Yes, right, this is better. Here's the updated

Re: [9] RFR: 8168921: Inconsistent Annotation.toString()

2016-10-31 Thread joe darcy
Hi Ivan, The code change in src look fine, but please update the existing test test/java/lang/annotation/AnnotationToStringTest.java rather than introducing a new test file. Thanks, -Joe On 10/29/2016 6:42 PM, Ivan Gerasimov wrote: Hello! Suppose an annotation is of form @interfa

[9] RFR: 8168921: Inconsistent Annotation.toString()

2016-10-29 Thread Ivan Gerasimov
Hello! Suppose an annotation is of form @interface MyAnnotation { long value(); } Create the annotation object with sun.reflect.annotation.AnnotationParser.annotationForMap(MyAnnotation.class, Map.of("value", some_value)). Annotation.toString() method, called for the object,