Re: [9] RFR (XS) JDK-8081771: ProcessTool.createJavaProcessBuilder() needs new addTestVmAndJavaOptions argument

2015-06-04 Thread David Holmes
Hi Chris, On 5/06/2015 9:34 AM, Chris Plummer wrote: On 6/3/15 11:31 PM, David Holmes wrote: Typo ... On 4/06/2015 4:04 PM, David Holmes wrote: Hi Chris, On 3/06/2015 1:20 PM, Chris Plummer wrote: Please review the following: Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/

Re: [9] RFR (XS) JDK-8081771: ProcessTool.createJavaProcessBuilder() needs new addTestVmAndJavaOptions argument

2015-06-03 Thread David Holmes
Typo ... On 4/06/2015 4:04 PM, David Holmes wrote: Hi Chris, On 3/06/2015 1:20 PM, Chris Plummer wrote: Please review the following: Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8081771 This review only concerns the changes to

Re: [9] RFR (XS) JDK-8081771: ProcessTool.createJavaProcessBuilder() needs new addTestVmAndJavaOptions argument

2015-06-03 Thread David Holmes
Hi Chris, On 3/06/2015 1:20 PM, Chris Plummer wrote: Please review the following: Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8081771 This review only concerns the changes to ProcessTool.java. The Your new method needs javado

Re: [9] RFR (XS) JDK-8081771: ProcessTool.createJavaProcessBuilder() needs new addTestVmAndJavaOptions argument

2015-06-03 Thread serguei.spit...@oracle.com
It looks good to me. Reviewed all together. Thanks, Serguei Thanks, Serguei On 6/2/15 8:20 PM, Chris Plummer wrote: Please review the following: Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8081771 This review only concerns th

Re: [9] RFR (XS) JDK-8081771: ProcessTool.createJavaProcessBuilder() needs new addTestVmAndJavaOptions argument

2015-06-03 Thread Roger Riggs
Hi Chris, The jdk testlibrary changes are fine. Roger On 6/2/2015 11:20 PM, Chris Plummer wrote: Please review the following: Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8081771 This review only concerns the changes to Proce

[9] RFR (XS) JDK-8081771: ProcessTool.createJavaProcessBuilder() needs new addTestVmAndJavaOptions argument

2015-06-02 Thread Chris Plummer
Please review the following: Webrev: http://cr.openjdk.java.net/~cjplummer/8054386/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8081771 This review only concerns the changes to ProcessTool.java. The CDSJDITests and filemapp.cpp changes will be committed under CR JDK-8054386, but th