Re: [9] RFR 8074839: Resolve disabled warnings for libunpack and the unpack200 binary

2015-03-19 Thread Kumar Srinivasan
Hi Mikael, First of all, thank you so much for doing this!. The changes look good. Kumar On 3/18/2015 4:18 PM, Mikael Vidstedt wrote: Please review the following change which fixes a number of native compilation warnings in the jdk.pack200 code. Bug:

Re: [9] RFR 8074839: Resolve disabled warnings for libunpack and the unpack200 binary

2015-03-18 Thread David Holmes
Hi Mikael, This all looks okay to me. Thanks, David On 19/03/2015 9:18 AM, Mikael Vidstedt wrote: Please review the following change which fixes a number of native compilation warnings in the jdk.pack200 code. Bug: https://bugs.openjdk.java.net/browse/JDK-8074839 Webrev:

[9] RFR 8074839: Resolve disabled warnings for libunpack and the unpack200 binary

2015-03-18 Thread Mikael Vidstedt
Please review the following change which fixes a number of native compilation warnings in the jdk.pack200 code. Bug: https://bugs.openjdk.java.net/browse/JDK-8074839 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8074839/webrev.03/webrev/ Testing: A slightly earlier version [1] has been