Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-10-17 Thread Volker Simonis
Hi Phil, thanks a lot for the review. Please see my comments inline: On Wed, Oct 16, 2013 at 12:48 AM, Phil Race philip.r...@oracle.com wrote: Hello Volker, I just remembered got back to these changes - my email inbox isn't a very good reminder system. I am OK with everything I see in the

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-10-15 Thread Phil Race
Hello Volker, I just remembered got back to these changes - my email inbox isn't a very good reminder system. I am OK with everything I see in the client areas except as below :- /* Very basic start for AIX - feel free to complete .. 169 */ We should remove this comment. If that means

RE: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-20 Thread Iris Clark
Hi, Volker. Just wanted to say that in addition to preparing for JavaOne (next week!), we're also busy fixing bugs in anticipation of JDK 8 ZBB milestone on 24 Oct [1]. Thanks, iris [1]: http://openjdk.java.net/projects/jdk8/milestones -Original Message- From: Phil Race Sent:

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-19 Thread Volker Simonis
Hi Phil, thank you for looking at the changes. Please find my answers inline: On Thu, Sep 19, 2013 at 12:22 AM, Phil Race philip.r...@oracle.com wrote: Volker, I've skimmed the client related changes - mostly based on the descriptions. I'll look in more detail as soon as I can after

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-19 Thread Phil Race
Hi, w.r.t the one issue below : is the awt load library code the only place you need/are doing this ? If someone else (hotspot, core-libs) already assented to this then I guess I could too but I'd like to hear for sure that hotspot and core-libs teams both agree to this approach and whether

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

2013-09-18 Thread Phil Race
Volker, I've skimmed the client related changes - mostly based on the descriptions. I'll look in more detail as soon as I can after JavaOne. We also have some engineers out on vacation who might want to look at these too. A couple of things that stood out : On AIX, fontconfig is not a standard