Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread naoto . sato
Looks good! Naoto On 5/30/20 3:40 PM, Lance Andersen wrote: All good Naoto Here is the revised diff — $ hg diff src/java.base/share/classes/java/util/regex/Pattern.java *diff -r 968b57610c0f src/java.base/share/classes/java/util/regex/Pattern.java* *--- a/src/java.base/share/classes/java

Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread Lance Andersen
All good Naoto Here is the revised diff — $ hg diff src/java.base/share/classes/java/util/regex/Pattern.java diff -r 968b57610c0f src/java.base/share/classes/java/util/regex/Pattern.java --- a/src/java.base/share/classes/java/util/regex/Pattern.java Sat May 30 10:33:28 2020 +0530 +++ b/src/

Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread naoto . sato
Thanks, Pavel. I think the year stays 2006 then. Sorry, Lance, for the false alarm. Naoto On 5/30/20 2:34 PM, Pavel Rappo wrote: I'm holding a copy in my hands right now. I can see "ISBN: 978-0-596-52812-6" written on the back of the book. Searching that number in the database yields the foll

Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread Pavel Rappo
I'm holding a copy in my hands right now. I can see "ISBN: 978-0-596-52812-6" written on the back of the book. Searching that number in the database yields the following record: Mastering Regular Expressions ISBN-13: 9780596528126 ISBN-10: 0596528124 Author: Friedl, Jeffrey E. F.

RFR: https://bugs.openjdk.java.net/browse/JDK-8246198 (formally: Re: [PATCH] Typo in java.util.regex.Pattern)

2020-05-30 Thread Lance Andersen
I create issue: https://bugs.openjdk.java.net/browse/JDK-8246198 for this typo Here is the updated diff $ hg diff src/java.base/share/classes/java/util/regex/Pattern.java diff -r 968b57610c0f src/java.base/share/classes/java/util/regex/

Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread Lance Andersen
Thank you Naoto, I am building now with both changes and will send a final diff out later along with the bug number! Best Lance > On May 30, 2020, at 2:13 PM, [email protected] wrote: > > Just noticed that the release year of the 3rd ed. should also be changed to > 2009 in the next line.

Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread naoto . sato
Just noticed that the release year of the 3rd ed. should also be changed to 2009 in the next line. Naoto On 5/30/20 4:02 AM, Lance Andersen wrote: I can sponsor this for you Best Lance -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network

Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread Pavel Rappo
Looks good. I can see that Lance has offered to sponsor that for you. (I was writing this message when I saw his reply.) I researched history a bit. That happened as one might guess quite trivially in November 2006: 2c2 < * @(#)Pattern.java 1.124 06/11/09 --- > * @(#)Pattern.java 1.125

Re: [PATCH] Typo in java.util.regex.Pattern

2020-05-30 Thread Lance Andersen
I can sponsor this for you Best Lance -- Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 [email protected] Sent from my iPhone > On May 29, 2020, at 10:25 PM, Hong Shao Yang wrote: > > Hi! > > I fo

[PATCH] Typo in java.util.regex.Pattern

2020-05-29 Thread Hong Shao Yang
Hi! I found a typo which has been long undetected in the documentation. In case you think this is worthwhile, I would appreciate it if someone can sponsor this patch. Cheers, Shao Yang = PATCH == diff --git a/src/java.base/share/classes/java/util/regex/Pattern.java b/src/java.b

[PATCH] Typo in java.util.regex.Pattern

2020-05-29 Thread Hong Shao Yang
Hi! I found a typo which has been long undetected in the documentation. In case you think this is worthwhile, I would appreciate it if someone can sponsor this patch. Cheers, Shao Yang = PATCH == diff --git a/src/java.base/share/classes/java/util/regex/Pattern.java b/src/java.b