> On Feb 18, 2020, at 2:00 PM, Mandy Chung wrote:
>
>
>
> On 2/18/20 4:50 AM, Severin Gehwolf wrote:
>> Hi Mandy,
>>
>> Thanks again for the review!
>>
>> Updated webrev:
>> incremental (only review changes):
>>
On 2/18/20 4:50 AM, Severin Gehwolf wrote:
Hi Mandy,
Thanks again for the review!
Updated webrev:
incremental (only review changes):
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webrev/
full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/webrev/
Hi Mandy,
Thanks again for the review!
Updated webrev:
incremental (only review changes):
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/incremental/webrev/
full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/11/webrev/
More below.
On Fri, 2020-02-14 at 18:16 -0800,
Hi Severin,
On 2/11/20 10:04 AM, Severin Gehwolf wrote:
Updated webrev:
Full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/10/webrev/
incremental:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/10/incremental/webrev/
Thanks for updating this. This patch looks okay in
I'll take a look next couple days. I was out last few days and am
catching up on other things.
Mandy
On 2/11/20 10:04 AM, Severin Gehwolf wrote:
Hi Mandy, Bob,
Thanks again for the reviews and patience on this. Sorry it took me so
long to get back to this :-/
Updated webrev:
Full:
I applied the delegation change that you recommended and now all container
tests pass.
Here’s the change that I applied.
echo +cpu +cpuset +io +memory +pids > /sys/fs/cgroup/cgroup.subtree_control
echo +cpu +cpuset +io +memory +pids >
/sys/fs/cgroup/user.slice/cgroup.subtree_control
echo +cpu
> On Feb 12, 2020, at 6:22 AM, Severin Gehwolf wrote:
>
> Hi Bob,
>
> On Tue, 2020-02-11 at 16:59 -0500, Bob Vandette wrote:
>> I applied your patch to the latest JDK 15 sources and ran the container
>> tests on Oracle Linux 8.1 with podman/cgroupv2 enabled. There were some
>> issues.
>>
Hi Bob,
On Tue, 2020-02-11 at 16:59 -0500, Bob Vandette wrote:
> I applied your patch to the latest JDK 15 sources and ran the container
> tests on Oracle Linux 8.1 with podman/cgroupv2 enabled. There were some
> issues.
> I’m not sure if its my setup or not.
Looking over them, they appear
I applied your patch to the latest JDK 15 sources and ran the container
tests on Oracle Linux 8.1 with podman/cgroupv2 enabled. There were some issues.
I’m not sure if its my setup or not.
I also ran the same build on Ubuntu with docker/cgroupv1. I didn't see any
failures on
the cgroupv1
Hi Mandy, Bob,
Thanks again for the reviews and patience on this. Sorry it took me so
long to get back to this :-/
Updated webrev:
Full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/10/webrev/
incremental:
> On Jan 22, 2020, at 11:06 AM, Mandy Chung wrote:
>
>
>
> On 1/22/20 1:53 AM, Severin Gehwolf wrote:
>> Hi Mandy,
>>
>> Thanks again for the review! I'll be sure to fix things. Some of the
>> issues you've pointed out probably pre-existed in old code. Some became
>> more complicated since
On 1/22/20 1:53 AM, Severin Gehwolf wrote:
Hi Mandy,
Thanks again for the review! I'll be sure to fix things. Some of the
issues you've pointed out probably pre-existed in old code. Some became
more complicated since unlimited in cgroupv1 is a large long value in
files. Anyway, I'll update
Hi Mandy,
Thanks again for the review! I'll be sure to fix things. Some of the
issues you've pointed out probably pre-existed in old code. Some became
more complicated since unlimited in cgroupv1 is a large long value in
files. Anyway, I'll update it.
On Tue, 2020-01-21 at 16:09 -0800, Mandy
Hi Severin,
Thanks for the update.
On 1/21/20 11:30 AM, Severin Gehwolf wrote:
Full: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/09/webrev/
incremental:
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/09/incremental/webrev/
I have answered my own question. Most of
Hi Mandy,
On Thu, 2020-01-16 at 17:43 -0800, Mandy Chung wrote:
> Hi Bob, Severin,
>
> On 1/9/20 11:51 AM, Severin Gehwolf wrote:
> > Thanks for the review! Should all be fixed now. Updated webrev:
> >
> > incremental:
> >
On 1/17/20 5:31 AM, Severin Gehwolf wrote:
If I understand you correctly, then we'd have to change how
-XshowSettings:system works currently with it. Not all metrics as
currently printed via LauncherHelper.java are supported in both worlds
(cgroup v1 & v2). It would make handling of cgroup
Hi Mandy,
On Thu, 2020-01-16 at 17:43 -0800, Mandy Chung wrote:
> Hi Bob, Severin,
>
> On 1/9/20 11:51 AM, Severin Gehwolf wrote:
> > Thanks for the review! Should all be fixed now. Updated webrev:
> >
> > incremental:
> >
Hi Bob, Severin,
On 1/9/20 11:51 AM, Severin Gehwolf wrote:
Thanks for the review! Should all be fixed now. Updated webrev:
incremental:http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/07/incremental/webrev/
full:http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/07/webrev/
gin forwarded message:
>
> From: Severin Gehwolf
> Subject: Re: [PING] RFR: 8231111: Cgroups v2: Rework Metrics in java.base so
> as to recognize unified hierarchy
> Date: January 13, 2020 at 4:21:18 AM EST
> To: Bob Vandette
>
> On Fri, 2020-01-10 at 13:16 -0500, Bob
> On Jan 13, 2020, at 4:04 AM, Severin Gehwolf wrote:
>
> Hi Bob,
>
> On Fri, 2020-01-10 at 11:50 -0500, Bob Vandette wrote:
>> Severin,
>>
>> The changes look ok to me. I assume you’ve run the container tests
>> on a cgroupv2 and cgroupv1 enabled system, right?
>
> Yes, I have.
>
>>
Hi Bob,
On Fri, 2020-01-10 at 11:50 -0500, Bob Vandette wrote:
> Severin,
>
> The changes look ok to me. I assume you’ve run the container tests
> on a cgroupv2 and cgroupv1 enabled system, right?
Yes, I have.
> You’re going to have to find a “R” reviewer.
Indeed.
> What’s the status of the
Severin,
The changes look ok to me. I assume you’ve run the container tests on a
cgroupv2 and cgroupv1 enabled system, right?
You’re going to have to find a “R” reviewer.
What’s the status of the hotspot cgroupv2 changes. Have these been reviewed?
Bob.
> On Jan 9, 2020, at 2:51 PM,
Hi,
On Fri, 2020-01-03 at 15:37 -0500, Bob Vandette wrote:
> Here are a few comments from scanning the webrev.
>
>
> It looks like you can remove line 151
>
>
Here are a few comments from scanning the webrev.
It looks like you can remove line 151
http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-823/06-incremental/webrev/src/java.base/linux/classes/jdk/internal/platform/CgroupSubsystemController.java.sdiff.html
151 int[] ints = new
Hi,
On 12/2/19 6:13 PM, Bob Vandette wrote:
2)
How should we deal with "not supported" for booleans/arrays, etc.?
Would it make sense to return record objects from the Metrics API so
that this could be dealt with? E.g.
Metrics m = ...
MetricResult result = m.getCpuSetCpus();
Hi Bob,
Sorry for the delay to get this updated.
Changes done in this latest webrev:
1. Rebased on top of 8226575: OperatingSystemMXBean should be made
container aware. File read ops now use privileged code.
2. Warning for mixed cgroup controllers and returning null for metrics.
> On Dec 2, 2019, at 3:33 PM, Severin Gehwolf wrote:
>
> On Mon, 2019-12-02 at 14:26 -0500, Bob Vandette wrote:
>>> On Dec 2, 2019, at 2:03 PM, Severin Gehwolf wrote:
>>>
>>> Hi Bob,
>>>
>>> On Mon, 2019-12-02 at 12:13 -0500, Bob Vandette wrote:
Sorry for the delay in responding. See
On Mon, 2019-12-02 at 14:26 -0500, Bob Vandette wrote:
> > On Dec 2, 2019, at 2:03 PM, Severin Gehwolf wrote:
> >
> > Hi Bob,
> >
> > On Mon, 2019-12-02 at 12:13 -0500, Bob Vandette wrote:
> > > Sorry for the delay in responding. See comments below:
> >
> > Thanks very much for taking a look
> On Dec 2, 2019, at 2:03 PM, Severin Gehwolf wrote:
>
> Hi Bob,
>
> On Mon, 2019-12-02 at 12:13 -0500, Bob Vandette wrote:
>> Sorry for the delay in responding. See comments below:
>
> Thanks very much for taking a look at this!
>
>>> On Nov 29, 2019, at 4:05 AM, Severin Gehwolf wrote:
Hi Bob,
On Mon, 2019-12-02 at 12:13 -0500, Bob Vandette wrote:
> Sorry for the delay in responding. See comments below:
Thanks very much for taking a look at this!
> > On Nov 29, 2019, at 4:05 AM, Severin Gehwolf wrote:
> >
> > On Fri, 2019-11-15 at 17:51 +0100, Severin Gehwolf wrote:
> > >
Sorry for the delay in responding. See comments below:
> On Nov 29, 2019, at 4:05 AM, Severin Gehwolf wrote:
>
> On Fri, 2019-11-15 at 17:51 +0100, Severin Gehwolf wrote:
>> Hi,
>>
>> Could I please get reviews of these core-libs, Linux-only, changes to
>> the Metrics subsystem? This patch
On Fri, 2019-11-15 at 17:51 +0100, Severin Gehwolf wrote:
> Hi,
>
> Could I please get reviews of these core-libs, Linux-only, changes to
> the Metrics subsystem? This patch implements cgroupv2 support for
> Metrics which are currently cgroupv1-only. Fedora 31 switched to
> cgroupv2 by default so
32 matches
Mail list logo
