On Sun, 13 Dec 2020 00:19:59 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:

> This is for JDK16, as a precursor to fixing JDK-8258002.
> 
> While it is good to be using localized strings in the generated output, the 
> significance for JDK-8258002 is that the strings are now obtained from a 
> resource file, and not hardcoded in JavaScript file itself.
> 
> The source file `search.js` is renamed to `search.js.template`, and (unlike 
> other template files) is copied as-is into the generated image. The values in 
> the template are resolved when javadoc is executed, depending on the locale 
> in use at the time. Because of the change in the file's extension, two 
> makefiles are updated to accommodate the new extension: one is for the 
> "interim" javadoc used to generate the API docs; the other is for the primary 
> javadoc in the main JDK image.

This pull request has now been integrated.

Changeset: 30ca0a5d
Author:    Jonathan Gibbons <j...@openjdk.org>
URL:       https://git.openjdk.java.net/jdk16/commit/30ca0a5d
Stats:     120 lines in 9 files changed: 87 ins; 6 del; 27 mod

8247994: Localize javadoc search

Reviewed-by: hannesw, ihse

-------------

PR: https://git.openjdk.java.net/jdk16/pull/16

Reply via email to