On Fri, 2 Jul 2021 19:36:01 GMT, Joe Wang wrote:
>> Thanks for the suggestion. I am happy with it as is, but I'll hold off
>> integrating it for now and rethink it later.
>
> Ok, good to know. Have a great weekend!
I am inclined to leave the wording alone barring serious objections to the
On Fri, 2 Jul 2021 19:08:09 GMT, Brian Burkhalter wrote:
>> Right. I understand. The intention was, unlike the overridden method that
>> returns 0 if len == 0 and -1 if at the end of the stream, this method
>> returns -1 in both cases. A careful reader, after comparing both methods,
>> would
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Fri, 2 Jul 2021 18:43:36 GMT, Joe Wang wrote:
>> Both conditions of the statement are intended to be met. If the stream is at
>> its end then
>>
>> if (pos >= count) {
>> return -1;
>> }
>>
>> will cause `-1` to be returned because at end of stream the condition
On Fri, 2 Jul 2021 17:40:08 GMT, Brian Burkhalter wrote:
>> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 161:
>>
>>> 159: * Unlike the {@link InputStream#read(byte[],int,int) overridden
>>> method}
>>> 160: * of {@code InputStream}, this method returns {@code
On Fri, 2 Jul 2021 17:27:34 GMT, Joe Wang wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 6766844: Correct error messages in test
>
> src/java.base/share/classes/java/io/ByteArrayInputStream.java line 161:
>
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Fri, 2 Jul 2021 16:58:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
On Fri, 2 Jul 2021 16:50:11 GMT, Naoto Sato wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 6766844: Correct error messages in test
>
> test/jdk/java/io/ByteArrayInputStream/ReadAllReadNTransferTo.java line
On Fri, 2 Jul 2021 16:55:18 GMT, Brian Burkhalter wrote:
>> Modify the specification of
>> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
>> returned instead of `0` when the stream is at its end and the third
>> parameter, `len`, is zero.
>
> Brian Burkhalter has
> Modify the specification of
> `java.io.ByteArrayInputStream#read(byte[],int,int)` to indicate that `-1` is
> returned instead of `0` when the stream is at its end and the third
> parameter, `len`, is zero.
Brian Burkhalter has updated the pull request incrementally with one additional
12 matches
Mail list logo
