Re: [jdk17] RFR: 8256919: BCEL: Utility.encode forget to close [v2]

2021-06-24 Thread Naoto Sato
On Thu, 24 Jun 2021 21:41:48 GMT, Joe Wang wrote: >> Fix a regression caused by the previous BCEL update. The issue was fixed in >> the current BCEL repo with a reversal of the previous code, adding back >> "gos.close();". Note however, doing so will result in a warning: [try] >> explicit

Re: [jdk17] RFR: 8256919: BCEL: Utility.encode forget to close

2021-06-24 Thread Joe Wang
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote: > Fix a regression caused by the previous BCEL update. The issue was fixed in > the current BCEL repo with a reversal of the previous code, adding back > "gos.close();". Note however, doing so will result in a warning: [try] > explicit call to

Re: [jdk17] RFR: 8256919: BCEL: Utility.encode forget to close [v2]

2021-06-24 Thread Joe Wang
> Fix a regression caused by the previous BCEL update. The issue was fixed in > the current BCEL repo with a reversal of the previous code, adding back > "gos.close();". Note however, doing so will result in a warning: [try] > explicit call to close() on an auto-closeable resource. This fix

Re: [jdk17] RFR: 8256919: BCEL: Utility.encode forget to close

2021-06-24 Thread Naoto Sato
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote: > Fix a regression caused by the previous BCEL update. The issue was fixed in > the current BCEL repo with a reversal of the previous code, adding back > "gos.close();". Note however, doing so will result in a warning: [try] > explicit call to

Re: [jdk17] RFR: 8256919: BCEL: Utility.encode forget to close

2021-06-24 Thread Brian Burkhalter
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote: > Fix a regression caused by the previous BCEL update. The issue was fixed in > the current BCEL repo with a reversal of the previous code, adding back > "gos.close();". Note however, doing so will result in a warning: [try] > explicit call to

Re: [jdk17] RFR: 8256919: BCEL: Utility.encode forget to close

2021-06-24 Thread Lance Andersen
On Thu, 24 Jun 2021 20:36:29 GMT, Joe Wang wrote: > Fix a regression caused by the previous BCEL update. The issue was fixed in > the current BCEL repo with a reversal of the previous code, adding back > "gos.close();". Note however, doing so will result in a warning: [try] > explicit call to

[jdk17] RFR: 8256919: BCEL: Utility.encode forget to close

2021-06-24 Thread Joe Wang
Fix a regression caused by the previous BCEL update. The issue was fixed in the current BCEL repo with a reversal of the previous code, adding back "gos.close();". Note however, doing so will result in a warning: [try] explicit call to close() on an auto-closeable resource. This fix calls