Re: [15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-13 Thread Steven R. Loomis
approve -- Steven R. Loomis | @srl295 | git.io/srl295 > El ene. 10, 2020, a las 4:02 p. m., naoto.s...@oracle.com escribió: > > Hi Steven, > > On 1/10/20 2:26 PM, Steven R. Loomis wrote: >> in Norm2AllModes.java and UBiDiProps.java and UCharacterProperty.java the >> stub name (icudt64b)

Re: [15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-13 Thread Roger Riggs
Looks fine to me also. Roger On 1/10/20 11:21 PM, Joe Wang wrote: I see. It's all good to me then. Best, Joe On 1/10/20 4:04 PM, naoto.s...@oracle.com wrote: Hi Joe, That data file seems no longer included in the ICU4J package (as of 64.2), thus I left it as it is. Naoto On 1/10/20

Re: [15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-10 Thread Joe Wang
I see. It's all good to me then. Best, Joe On 1/10/20 4:04 PM, naoto.s...@oracle.com wrote: Hi Joe, That data file seems no longer included in the ICU4J package (as of 64.2), thus I left it as it is. Naoto On 1/10/20 2:57 PM, Joe Wang wrote: Is there a reason why uidna.spp was left out

Re: [15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-10 Thread naoto . sato
Hi Steven, On 1/10/20 2:26 PM, Steven R. Loomis wrote: in Norm2AllModes.java and UBiDiProps.java  and UCharacterProperty.java the stub name (icudt64b) should be calculated from the version number.  At least put “icudt64b” in one place and refer to it. Good point. Modified as suggested:

Re: [15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-10 Thread naoto . sato
Hi Joe, That data file seems no longer included in the ICU4J package (as of 64.2), thus I left it as it is. Naoto On 1/10/20 2:57 PM, Joe Wang wrote: Is there a reason why uidna.spp was left out of the move? -Joe On 1/10/20 2:02 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix

Re: [15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-10 Thread Joe Wang
Is there a reason why uidna.spp was left out of the move? -Joe On 1/10/20 2:02 PM, naoto.s...@oracle.com wrote: Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8174270 The proposed changeset is located at:

Re: [15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-10 Thread Steven R. Loomis
in Norm2AllModes.java and UBiDiProps.java and UCharacterProperty.java the stub name (icudt64b) should be calculated from the version number. At least put “icudt64b” in one place and refer to it. OR keep the data file names unversioned, such as

[15] RFR: 8174270: Consolidate ICU sources in one location

2020-01-10 Thread naoto . sato
Hi, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8174270 The proposed changeset is located at: https://cr.openjdk.java.net/~naoto/8174270/webrev.00/ Although the number of modified files are huge, the change is simply moving the scattered ICU