Re: [15] RFR: 8239480: Support for CLDR version 37

2020-05-22 Thread Roger Riggs
Looks fine. On 5/20/20 5:31 PM, naoto.s...@oracle.com wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8239480 The proposed changeset, and the release note draft are located at: https://cr.openjdk.java.net/~naoto/8239480/webrev.00/

Re: [15] RFR: 8239480: Support for CLDR version 37

2020-05-20 Thread Joe Wang
On 5/20/2020 7:06 PM, naoto.s...@oracle.com wrote: Hi Joe, thanks again! No problem. The license file "unicode-license.txt" is actually included in the version 37 artifact: https://github.com/unicode-org/cldr/blob/release-37/unicode-license.txt The changeset uses the file as is, so I

Re: [15] RFR: 8239480: Support for CLDR version 37

2020-05-20 Thread naoto . sato
Hi Joe, thanks again! The license file "unicode-license.txt" is actually included in the version 37 artifact: https://github.com/unicode-org/cldr/blob/release-37/unicode-license.txt The changeset uses the file as is, so I believe it is OK. Naoto On 5/20/20 6:51 PM, Joe Wang wrote: Looks

Re: [15] RFR: 8239480: Support for CLDR version 37

2020-05-20 Thread Joe Wang
Looks good to me. A minor comment: in the license files, Terms of Use lost its original format (e.g. headings and numbering), lines are also super long. But I think we've seen them in the previous update, it's up to you whether you'd want to reformat

[15] RFR: 8239480: Support for CLDR version 37

2020-05-20 Thread naoto . sato
Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8239480 The proposed changeset, and the release note draft are located at: https://cr.openjdk.java.net/~naoto/8239480/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8243581 This updates the