Re: [OpenJDK 2D-Dev] Fwd: Need reviewers: more predictable binaries

2012-09-06 Thread Kelly O'Hair
Typically, the macros COMPILE.c, COMPILE.CC, and COMPILE.m will include $(CPPFLAGS) which is the preprocessing flags for any compilations using a preprocessor. I was trying to make the minimum changes needed to get this additional -D option on all the compile lines. I am pretty sure this works,

Re: [OpenJDK 2D-Dev] Fwd: Need reviewers: more predictable binaries

2012-09-06 Thread Mike Swingler
My strong suspicion is that the JDK Makefiles only use CFLAGS, not CPPFLAGS for .m files. CPPFLAGS should be used for .mm files (but those should be really rare). Regards, Mike Swingler Apple Inc. On Sep 6, 2012, at 11:35 AM, Scott Kovatch wrote: > I feel like I should be able to find the ans

Re: [OpenJDK 2D-Dev] Fwd: Need reviewers: more predictable binaries

2012-09-06 Thread Scott Kovatch
I feel like I should be able to find the answer to this, but does Objective-C use CPPFLAGS? I can't tell if these changes would apply to .m or .mm files. It certainly appears to be the intent of the change, since a number of .m files in the AWT were changed to use THIS_FILE. -- Scott K. On Sep