Re: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out

2011-06-21 Thread Vincent Ryan
Apologies for overlooking the core-libs audience. On 06/20/11 23:42, Joe Darcy wrote: Vincent Ryan wrote: On 06/20/11 16:08, Alan Bateman wrote: Vincent Ryan wrote: : Thanks Alan. JNDI applications are encouraged to call close() rather than rely on GC to free resources. I guess

Re: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out

2011-06-19 Thread Alan Bateman
Rémi Forax wrote: Looks good. By the way, why javax.naming.Context was not retrofitted to implement AutoCloseable. Thanks Rémi, thanks Vinnie. I was wondering about Context too as it appears, on the surface anyway, that it could extend AutoCloseable. I believe Joe used an annotation

Re: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out

2011-06-19 Thread Joe Darcy
Alan Bateman wrote: Rémi Forax wrote: Looks good. By the way, why javax.naming.Context was not retrofitted to implement AutoCloseable. Thanks Rémi, thanks Vinnie. I was wondering about Context too as it appears, on the surface anyway, that it could extend AutoCloseable. I believe Joe used

7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out

2011-06-18 Thread Alan Bateman
I need a reviewer for a small fix to a test that I caught looping on my system. The test creates a server thread that emulates a non responding LDAP server. Unfortunately the thread goes into a loop reading from the connection once it is closed. I'll bet the original author only tested this

Re: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out

2011-06-18 Thread Rémi Forax
On 06/18/2011 09:39 PM, Alan Bateman wrote: I need a reviewer for a small fix to a test that I caught looping on my system. The test creates a server thread that emulates a non responding LDAP server. Unfortunately the thread goes into a loop reading from the connection once it is closed.

Re: 7056489: test/com/sun/jndi/ldap/ReadTimeoutTest.java loops or times out

2011-06-18 Thread Vincent Ryan
Your fix looks good. On 18/06/2011 20:39, Alan Bateman wrote: I need a reviewer for a small fix to a test that I caught looping on my syst.em. The test creates a server thread that emulates a non responding LDAP server. Unfortunately the thread goes into a loop reading from the connection once