Re: 8016217: More javadoc warnings

2013-06-11 Thread Joe Darcy
On 6/11/2013 5:33 AM, Alan Bateman wrote: On 11/06/2013 13:08, Sean Mullan wrote: The changes to classes in the security component look fine. One question I have is about the change to javax/xml/crypto/dsig/Manifest.java. Was there a specific error here or did you just want to make this cleane

Re: 8016217: More javadoc warnings

2013-06-11 Thread Alan Bateman
On 11/06/2013 13:08, Sean Mullan wrote: The changes to classes in the security component look fine. One question I have is about the change to javax/xml/crypto/dsig/Manifest.java. Was there a specific error here or did you just want to make this cleaner by removing all of the html special char

Re: 8016217: More javadoc warnings

2013-06-11 Thread Sean Mullan
The changes to classes in the security component look fine. One question I have is about the change to javax/xml/crypto/dsig/Manifest.java. Was there a specific error here or did you just want to make this cleaner by removing all of the html special character handling? The reason I ask is that

Re: 8016217: More javadoc warnings

2013-06-10 Thread Mike Duigou
I took a pass through the patch and nothing leaped out at me either. I wondered about the use of   to prevent an expression from breaking across lines but decided it's OK. On Jun 10 2013, at 03:31 , Alan Bateman wrote: > > About 8 months ago I tried an early build of doclint [1] and used it to

Re: 8016217: More javadoc warnings

2013-06-10 Thread Alan Bateman
On 10/06/2013 18:29, Iris Clark wrote: Hi, Alan. The changes look good to me. One thing caught my eye. In java.util.Calendar, around lines 2681 and later around 2702 you removed the "" --- old/src/share/classes/java/util/Calendar.java 2013-06-10 10:37:52.585879060 +0100 +++ new/src/sh

RE: 8016217: More javadoc warnings

2013-06-10 Thread Iris Clark
l && @@ -83,7 +83,7 @@ * ... * java.util.Arrays.fill(passwd, ' '); * } - * + * } * * @author Xueming Shen * @since 1.6 Was the removal intentional? Thanks, iris -Original Message- From: Alan Bateman Sent: Monday, June 10, 2013 3:32 AM To: core-

Re: 8016217: More javadoc warnings

2013-06-10 Thread Lance Andersen - Oracle
This looks good. Thank you for taking this on Alan. Best Lance On Jun 10, 2013, at 6:31 AM, Alan Bateman wrote: > > About 8 months ago I tried an early build of doclint [1] and used it to fix > up a bunch issues at the time [2]. It's been awhile, so I decided to try out > the latest version t

Re: 8016217: More javadoc warnings

2013-06-10 Thread Chris Hegarty
I eyeballed the patch file. Looks fine to me. It is really nice to have a tool to that operates on the actual source. -Chris. On 10/06/2013 11:31, Alan Bateman wrote: About 8 months ago I tried an early build of doclint [1] and used it to fix up a bunch issues at the time [2]. It's been awhil

8016217: More javadoc warnings

2013-06-10 Thread Alan Bateman
About 8 months ago I tried an early build of doclint [1] and used it to fix up a bunch issues at the time [2]. It's been awhile, so I decided to try out the latest version to see how it has progressed. All I can say is "Yikes". The good news is that they reported against the original source

hg: jdk8/tl/jdk: 8016217: More javadoc warnings

2013-06-10 Thread alan . bateman
Changeset: d790064850a7 Author:alanb Date: 2013-06-10 12:58 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d790064850a7 8016217: More javadoc warnings Reviewed-by: lancea, chegar, psandoz ! src/share/classes/java/io/BufferedInputStream.java ! src/share/classes/java/io