On 09.08.2016 15:58, Claes Redestad wrote:
On 2016-08-09 14:41, Ivan Gerasimov wrote:
Hi Claes!
Not a thorough review, but a minor comment.
209 .replaceAll("DMH.invoke", "DMH/.invoke")
The dot in the regexp needs to be escaped here.
"Needs" is a strong word her
On 2016-08-09 14:41, Ivan Gerasimov wrote:
Hi Claes!
Not a thorough review, but a minor comment.
209 .replaceAll("DMH.invoke", "DMH/.invoke")
The dot in the regexp needs to be escaped here.
"Needs" is a strong word here, but I agree it's more correct. I'll fix
an
> On 9 Aug 2016, at 13:26, Claes Redestad wrote:
>
>
>
> On 2016-08-09 13:48, Claes Redestad wrote:
>> Hi,
>>
>> change to enable DMH pre-generation caused a subtle change in the
>> stacktrace, which caused this test to fail.
>>
>> Please review this patch which reverts the stackframe to lo
Hi Claes!
Not a thorough review, but a minor comment.
209 .replaceAll("DMH.invoke", "DMH/.invoke")
The dot in the regexp needs to be escaped here.
With kind regards,
Ivan
On 09.08.2016 15:26, Claes Redestad wrote:
On 2016-08-09 13:48, Claes Redestad wrote:
Hi,
On 2016-08-09 13:48, Claes Redestad wrote:
Hi,
change to enable DMH pre-generation caused a subtle change in the
stacktrace, which caused this test to fail.
Please review this patch which reverts the stackframe to look like
before for non-pregenerated DMHs, while also updating the test to
Hi,
change to enable DMH pre-generation caused a subtle change in the
stacktrace, which caused this test to fail.
Please review this patch which reverts the stackframe to look like
before for non-pregenerated DMHs, while also updating the test to accept
pregenerated DMHs.
To verify this wo
