Re: 8169001: Remove launcher's built-in ergonomics

2016-11-09 Thread Chris Bensen
> On Nov 9, 2016, at 10:13 AM, David DeHaven wrote: > > > Please review the fix for: > https://bugs.openjdk.java.net/browse/JDK-8169001 > > Webrev at: > http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Overall this looks like a

Re: 8169001: Remove launcher's built-in ergonomics

2016-11-09 Thread David DeHaven
Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ >>> >>> Overall this looks like a complete eradication of the launcher >>> ergonomics. A few specific comments: >>> >>>

Re: 8169001: Remove launcher's built-in ergonomics

2016-11-08 Thread David Holmes
Hi Kumar, FYI regarding the test, I was mis-remembering - it was actually an issue with the VM's notion of is_server_class_machine(), not the launcher. It's used for GC ergonomic selection. Cheers, David On 9/11/2016 3:28 AM, Kumar Srinivasan wrote: Hi David, Thanks for the review please

Re: 8169001: Remove launcher's built-in ergonomics

2016-11-08 Thread Kumar Srinivasan
Hi David, Thanks for the review please see embedded comments: Hi Kumar, On 8/11/2016 4:47 AM, Kumar Srinivasan wrote: Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Overall this looks

Re: 8169001: Remove launcher's built-in ergonomics

2016-11-08 Thread Erik Joelsson
Build changes look ok. /Erik On 2016-11-07 19:47, Kumar Srinivasan wrote: Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Background: Launcher ergonomics was introduced last decade to help

Re: 8169001: Remove launcher's built-in ergonomics

2016-11-07 Thread David Holmes
Hi Kumar, On 8/11/2016 4:47 AM, Kumar Srinivasan wrote: Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Overall this looks like a complete eradication of the launcher ergonomics. A few

8169001: Remove launcher's built-in ergonomics

2016-11-07 Thread Kumar Srinivasan
Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8169001 Webrev at: http://cr.openjdk.java.net/~ksrini/8169001/webrev.00/ Background: Launcher ergonomics was introduced last decade to help determine if the execution system is "Server Class", this was necessary to