Re: 8196830: publicLookup().findVirtual should not return method handle to AccessibleObject.setAccessible

2018-02-20 Thread Paul Sandoz
Looks good, especially the test. Paul. > On Feb 20, 2018, at 10:21 AM, mandy chung wrote: > > This patch looks good. It's unfortunate that setAccessible was not final > to begin with. I agree that this fix is a good compromise with a simple > fix and low

Re: 8196830: publicLookup().findVirtual should not return method handle to AccessibleObject.setAccessible

2018-02-20 Thread mandy chung
This patch looks good.  It's unfortunate that setAccessible was not final to begin with.  I agree that this fix is a good compromise with a simple fix and low incompatibility.   Is there a CSR to review? Mandy On 2/19/18 8:57 AM, Alan Bateman wrote: > AccessibleObject's setAccessible(boolean)

8196830: publicLookup().findVirtual should not return method handle to AccessibleObject.setAccessible

2018-02-19 Thread Alan Bateman
AccessibleObject's setAccessible(boolean) is currently not caller sensitive but the overrides in Method/Field/Constructor are. This awkwardness stems from its constructor being protected and the method not being final. It is thus possible to extend the class outside of the java.lang.reflect