Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

2020-05-29 Thread James Laskey
Missed that it was a backout. 📱 > On May 29, 2020, at 11:18 PM, James Laskey wrote: > > You may not have intended this comment. s/offset/scale/ > 49 > 50 // Cached array base offset > 51 private static final long ARRAY_INDEX_SCALE = > UNSAFE.arrayIndexScale($type$[].class); > >

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

2020-05-29 Thread James Laskey
You may not have intended this comment. s/offset/scale/ 49 50 // Cached array base offset 51 private static final long ARRAY_INDEX_SCALE = UNSAFE.arrayIndexScale($type$[].class); 📱 > On May 29, 2020, at 11:05 PM, Mikael Vidstedt > wrote: > >  > Looks good, thanks for fixing!

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

2020-05-29 Thread Brian Burkhalter
Thanks. Pushed. Brian > On May 29, 2020, at 7:10 PM, Stuart Marks wrote: > > OK, looks good. Thanks for jumping on this quickly. > > s'marks > > On 5/29/20 7:01 PM, Brian Burkhalter wrote: >> Please review this fix [1] for [2]. It in effect just backs out the recent >> fix for [3]. I’ll inve

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

2020-05-29 Thread Stuart Marks
OK, looks good. Thanks for jumping on this quickly. s'marks On 5/29/20 7:01 PM, Brian Burkhalter wrote: Please review this fix [1] for [2]. It in effect just backs out the recent fix for [3]. I’ll investigate the root cause next week. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/824618

Re: 8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

2020-05-29 Thread Mikael Vidstedt
Looks good, thanks for fixing! Cheers, Mikael > On May 29, 2020, at 7:01 PM, Brian Burkhalter > wrote: > > Please review this fix [1] for [2]. It in effect just backs out the recent > fix for [3]. I’ll investigate the root cause next week. > > Thanks, > > Brian > > [1] http://cr.openjdk

8246183: Scanner/ScanTest.java fails due to SIGSEGV in StubRoutines::jshort_disjoint_arraycopy

2020-05-29 Thread Brian Burkhalter
Please review this fix [1] for [2]. It in effect just backs out the recent fix for [3]. I’ll investigate the root cause next week. Thanks, Brian [1] http://cr.openjdk.java.net/~bpb/8246183/webrev.00/ [2] https://bugs.openjdk.java.net/browse/JDK-8246183 [3] https://bugs.openjdk.java.net/browse/J