The class comment to Attributes says> > This map and its views have a
predictable iteration order, namely the> order that keys were inserted
into the map, as with {@link LinkedHashMap}.>
Considering above statement, are two Attributes equal if they contain
the same mappings in a different iteration
On 25/01/2019 19:44, Lance Andersen wrote:
Thank you Joe.
So the change is (see bolded change):
$ hg diff
diff -r 6130409b923e src/java.base/share/classes/java/util/jar/Attributes.java
--- a/src/java.base/share/classes/java/util/jar/Attributes.java Thu Jan 24
10:57:31 2019 -0800
+++ b/src/java
I don't mind if Intellij is happier :-)
-Joe
On 1/25/2019 12:05 PM, Lance Andersen wrote:
While this works fine in the generated javadoc {@linkplain map map}
This makes intellij a bit happier : {@linkplain Attributes#map map}
-
$ hg diff
diff -r 6130409b923e
src/java.b
While this works fine in the generated javadoc {@linkplain map map}
This makes intellij a bit happier : {@linkplain Attributes#map map}
-
$ hg diff
diff -r 6130409b923e src/java.base/share/classes/java/util/jar/Attributes.java
--- a/src/java.base/share/classes/java/util/ja
Hi Joe
yes I checked it in my local build and it does take me to map field via the
link
Best
Lance
> On Jan 25, 2019, at 2:49 PM, Joe Darcy wrote:
>
> Hi Lance,
>
> Assuming the javadoc renders as expected, the new version looks good to me :-)
>
> Thanks,
> -Joe
> On 1/25/2019 11:44 AM, Lan
Hi Lance,
Assuming the javadoc renders as expected, the new version looks good to
me :-)
Thanks,
-Joe
On 1/25/2019 11:44 AM, Lance Andersen wrote:
Thank you Joe.
So the change is (see bolded change):
$ hg diff
diff -r 6130409b923e
src/java.base/share/classes/java/util/jar/Attributes.java
Thank you Joe.
So the change is (see bolded change):
$ hg diff
diff -r 6130409b923e src/java.base/share/classes/java/util/jar/Attributes.java
--- a/src/java.base/share/classes/java/util/jar/Attributes.java Thu Jan 24
10:57:31 2019 -0800
+++ b/src/java.base/share/classes/java/util/jar/Attributes.
To clarify the CSR comments, for "underlying map" I meant for "map" to
be a link to the protected field named "map".
Thanks,
-Joe
On 1/25/2019 11:24 AM, Roger Riggs wrote:
Looks fine, Lance
Roger
On 01/25/2019 02:22 PM, Lance Andersen wrote:
The CSR review suggested a slight update to the
Looks fine, Lance
Roger
On 01/25/2019 02:22 PM, Lance Andersen wrote:
The CSR review suggested a slight update to the proposed wording:
———
$ hg diff
diff -r 6130409b923e src/java.base/share/classes/java/util/jar/Attributes.java
--- a/src/java.base/share/classes/java/util/jar/Attributes.ja
The CSR review suggested a slight update to the proposed wording:
———
$ hg diff
diff -r 6130409b923e src/java.base/share/classes/java/util/jar/Attributes.java
--- a/src/java.base/share/classes/java/util/jar/Attributes.java Thu Jan 24
10:57:31 2019 -0800
+++ b/src/java.base/share/classes/java/
+1 to retaining and correcting the javadoc to match the implementation.
Thanks, Roger
On 01/22/2019 07:47 PM, Lance Andersen wrote:
On Jan 22, 2019, at 12:02 PM, Alan Bateman wrote:
On 19/01/2019 12:46, Lance Andersen wrote:
Hi all,
Please review the fix for JDK-8217393 which updates the j
> On Jan 22, 2019, at 12:02 PM, Alan Bateman wrote:
>
> On 19/01/2019 12:46, Lance Andersen wrote:
>> Hi all,
>>
>> Please review the fix for JDK-8217393 which updates the javadocs for
>> Attriibutes::equals to clarify its behavior to match its implementation
>>
>> —
>> hg diff
>> diff
On 19/01/2019 12:46, Lance Andersen wrote:
Hi all,
Please review the fix for JDK-8217393 which updates the javadocs for
Attriibutes::equals to clarify its behavior to match its implementation
—
hg diff
diff -r c5d6b4480c6c src/java.base/share/classes/java/util/jar/Attributes.java
--- a/sr
Looks OK but I would consider simply deleting the javadoc for equals
(and hashCode) completely.
We don't really have anything to add to the Map interface spec.
On Sat, Jan 19, 2019 at 4:47 AM Lance Andersen
wrote:
>
> Hi all,
>
> Please review the fix for JDK-8217393 which updates the javadocs
Hi all,
Please review the fix for JDK-8217393 which updates the javadocs for
Attriibutes::equals to clarify its behavior to match its implementation
—
hg diff
diff -r c5d6b4480c6c src/java.base/share/classes/java/util/jar/Attributes.java
--- a/src/java.base/share/classes/java/util/jar/Attr
Hi Philipp,
I suspect the behavior dates back to the original implementation in JDK 1.2. I
am not sure it should be changed at this point though the javadocs should be
updated.
Best
Lance
> On Jan 17, 2019, at 5:53 PM, Philipp Kunz wrote:
>
> Hi,
>
> In the JavaDoc comment for java.util.jar
Hi,
In the JavaDoc comment for java.util.jar.Attributes#equals on line 269
it says:
[...] Returns true if the given object is also an instance of
Attributes [...]
but that is not actually true. Passing a LinkedHashMap results also in
true returned given equal content of both maps.
Comment and impl
17 matches
Mail list logo
