It turns out there's a problem with these changes as it didn't remove
the code to load the rmi library (we missed it in the code review too).
The result is that most of the RMI tests are now failing. I've just
created 7104577 for this. The diffs are trivial - can I get a reviewer
and we'll
D'oh! Sorry my fault.
The changes look good, and thanks for taking care of this.
-Chris.
On 10/25/11 09:08 AM, Alan Bateman wrote:
It turns out there's a problem with these changes as it didn't remove
the code to load the rmi library (we missed it in the code review too).
The result is that
Looks good from me as well. Seems like a strange location to have the load
library!
Mike
On Oct 25 2011, at 01:08 , Alan Bateman wrote:
It turns out there's a problem with these changes as it didn't remove the
code to load the rmi library (we missed it in the code review too). The
It appears that the only function of librmi is to export the VM function
JVM_LatestUserDefinedLoader. It seems really silly to have a whole
native library to perform such a trivial operation.
JVM_LatestUserDefinedLoader is also used in java.io.ObjectInputStream.
It would make more sense to
Looks good. Nice catch.
Mike
On Oct 24 2011, at 07:20 , Chris Hegarty wrote:
It appears that the only function of librmi is to export the VM function
JVM_LatestUserDefinedLoader. It seems really silly to have a whole native
library to perform such a trivial operation.
Thanks Mike,
It was actually Alan that caught this. Crazy that someone ( at some time
) even thought this was a good idea!
-Chris.
On 24/10/2011 15:41, Mike Duigou wrote:
Looks good. Nice catch.
Mike
On Oct 24 2011, at 07:20 , Chris Hegarty wrote:
It appears that the only function of
On 24/10/2011 15:20, Chris Hegarty wrote:
It appears that the only function of librmi is to export the VM
function JVM_LatestUserDefinedLoader. It seems really silly to have a
whole native library to perform such a trivial operation.
JVM_LatestUserDefinedLoader is also used in
On 25/10/2011 12:47 AM, Chris Hegarty wrote:
Thanks Mike,
It was actually Alan that caught this. Crazy that someone ( at some time
) even thought this was a good idea!
Not only did someone think it a good idea but nobody else disagreed.
Sometimes these things are lost in ancient history but
