Code Review 7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util

2011-10-25 Thread Chris Hegarty
The changes to remove warnings from the NIO code (7068616) missed java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not spotted at the time as the compiler was not generating raw type warnings for anonymous inner classes. It does now, see CR 7090499. This is not an issue when

Re: Code Review 7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util

2011-10-25 Thread Maurizio Cimadamore
Approved Maurizio On 25/10/11 13:36, Chris Hegarty wrote: The changes to remove warnings from the NIO code (7068616) missed java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not spotted at the time as the compiler was not generating raw type warnings for anonymous inner

Re: Code Review 7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util

2011-10-25 Thread Alan Bateman
On 25/10/2011 13:36, Chris Hegarty wrote: The changes to remove warnings from the NIO code (7068616) missed java/nio/charset/Charset.java and sun/nio/ch/Util.java. This was not spotted at the time as the compiler was not generating raw type warnings for anonymous inner classes. It does now,

Re: Code Review 7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util

2011-10-25 Thread Chris Hegarty
Alan, I found the same problem in the net and security makefiles, incremental build fails because of raw type warnings. I can file another CR or amend the category and description of this one, to be more generic. The changes are similarity trivial: hg diff

Re: Code Review 7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util

2011-10-25 Thread Alan Bateman
On 25/10/2011 15:32, Chris Hegarty wrote: Alan, I found the same problem in the net and security makefiles, incremental build fails because of raw type warnings. I can file another CR or amend the category and description of this one, to be more generic. Might as well fix these with the

Re: Code Review 7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util

2011-10-25 Thread Ulf Zibis
All looks fine to me. -Ulf Am 25.10.2011 16:32, schrieb Chris Hegarty: Alan, I found the same problem in the net and security makefiles, incremental build fails because of raw type warnings. I can file another CR or amend the category and description of this one, to be more generic. The

Re: Code Review 7104650: rawtype warnings in java.nio.charset.Charset and sun.nio.ch.Util

2011-10-25 Thread David Holmes
I'll belatedly add my thumbs up. Thanks Chris! David On 26/10/2011 12:55 AM, Ulf Zibis wrote: All looks fine to me. -Ulf Am 25.10.2011 16:32, schrieb Chris Hegarty: Alan, I found the same problem in the net and security makefiles, incremental build fails because of raw type warnings. I