On 04/17/2012 12:26 AM, Stuart Marks wrote:
On 4/16/12 1:18 PM, Kurchi Hazra wrote:
Sorry, I forgot to insert a link to the webrev :
http://cr.openjdk.java.net/~khazra/7157893/webrev.02/
On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit
On 4/16/12 1:18 PM, Kurchi Hazra wrote:
Sorry, I forgot to insert a link to the webrev :
http://cr.openjdk.java.net/~khazra/7157893/webrev.02/
On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit. Just a few notes
EnumMap.java:
maskNull s
Sorry, I forgot to insert a link to the webrev :
http://cr.openjdk.java.net/~khazra/7157893/webrev.02/
- Kurchi
On 4/16/2012 12:31 PM, Kurchi Hazra wrote:
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit. Just a few notes
EnumMap.java:
maskNull seemed to have the unchecked
On 4/13/2012 8:26 PM, Mike Duigou wrote:
Looks good for commit. Just a few notes
EnumMap.java:
maskNull seemed to have the unchecked cast well bottlenecked. Why move the cast outside
of unmaskNull() and thus require @SuppressWarnings("unchecked") in many other
places.
I agree with this o
Looks good for commit. Just a few notes
- The inconsistent use of by WeakHashMap and by the other Hash Map
classes for their tables is a bit annoying but not a new problem. We should
either make all of the maps use (my preference) or all use . There
were lots of cases of introduced and tha
On 4/11/12 4:42 AM, Rémi Forax wrote:
On 04/07/2012 02:35 AM, Stuart Marks wrote:
In order to program effectively with generics, I think you have to understand
erasure and its implications. It may have been an unfortunate choice, but
erasure is part of the language and we have to deal with it an
Thanks for the updates. They look fine to me.
I think Mike Duigou was still looking at the changes; I'd suggest waiting for
him to respond.
s'marks
On 4/10/12 4:15 PM, Kurchi Hazra wrote:
Hi Stuart,
Please find the updated webrev here:
http://cr.openjdk.java.net/~khazra/7157893/webrev.01/
On 04/11/2012 10:06 PM, Mike Duigou wrote:
This thread has gone on long enough I've lost track of the reasoning behind
some of the choices.
Specifically, I'm wondering why Entry[] is preferred over Entry[] for
HashMap and Hashtable. Understandably is needed to the array creation but the
tech
This thread has gone on long enough I've lost track of the reasoning behind
some of the choices.
Specifically, I'm wondering why Entry[] is preferred over Entry[] for
HashMap and Hashtable. Understandably is needed to the array creation but
the technique used by WeakHashMap would seem to be eq
On 04/07/2012 02:35 AM, Stuart Marks wrote:
Hi Kurchi, I think we've converged on the code changes. Please prepare
and post another webrev for a final cross-check before pushing.
What follows is I think merely residual disagreement over the
philosophy of how to handle generic casts vs reificat
Hi Stuart,
Please find the updated webrev here:
http://cr.openjdk.java.net/~khazra/7157893/webrev.01/
I hope to have included all the suggestions correctly. Also, note that I
made some new changes in Hashtable.java at lines 185, 355 and 910 to get
rid of some additional warnings.
Thanks
On 4/5/12 12:08 AM, Stuart Marks wrote:
src/share/classes/java/util/PropertyPermission.java
--
- L599 this is another case of "laundering" a conversion through a raw type
(similar to Collections.java above), as we can't directly
Hi Kurchi, I think we've converged on the code changes. Please prepare and post
another webrev for a final cross-check before pushing.
What follows is I think merely residual disagreement over the philosophy of how
to handle generic casts vs reification. :-)
On 4/6/12 3:06 AM, Rémi Forax wrot
On 04/05/2012 11:04 PM, Stuart Marks wrote:
[...]
I was going to suggest adding a comment to explain this but I
suspect that
would make this code even more confusing.
just perhaps something saying it's a known limitation of the type-system
Yeah, probably something like "need to cast to r
On 4/5/12 1:12 AM, Rémi Forax wrote:
On 04/05/2012 09:08 AM, Stuart Marks wrote:
src/share/classes/java/util/Collections.java
--
- L1408 this casts to a raw Set in the parameter to super(). There was some
discussion about this
On 04/05/2012 09:08 AM, Stuart Marks wrote:
Hi Kurchi, Remi,
Sorry for the delay in this review. There were a lot of files to go
through, and I wanted to dig up some history as well. (I've also been
busy) There are no real major issues, but I wanted to clear a
couple things up and possibl
Hi Kurchi, Remi,
Sorry for the delay in this review. There were a lot of files to go through,
and I wanted to dig up some history as well. (I've also been busy) There
are no real major issues, but I wanted to clear a couple things up and possibly
file issues for further work.
Comments fo
Hi Kurchi,
I've re-reviewed the file you merged, it's Ok for me.
Rémi
On 03/30/2012 02:15 AM, Kurchi Hazra wrote:
Hi,
These changes cleanup warnings in java.util.* and were contributed
by Remi Forax (fo...@univ-mlv.fr).
Specifically the files that I merged/had conflicts are:
src/share/
Hi,
These changes cleanup warnings in java.util.* and were contributed by
Remi Forax (fo...@univ-mlv.fr).
Specifically the files that I merged/had conflicts are:
src/share/classes/java/util/Currency.java
src/share/classes/java/util/EnumMap.java
src/share/classes/java/util/PropertyPermissio
19 matches
Mail list logo
