Re: Code review request for 6897550 BigInteger constructor should use local cached String length

2009-11-03 Thread Joseph D. Darcy
Andrew John Hughes wrote: 2009/11/3 Joseph D. Darcy : Hello. Please review this simple change to replace several calls to val.length() with an already cached copy of val.length(); patch below. 6897550 BigInteger constructor should use local cached String length http://cr.openjdk.java.net/~d

Re: Code review request for 6897550 BigInteger constructor should use local cached String length

2009-11-03 Thread Christopher Hegarty -Sun Microsystems Ireland
Thanks Joe, looks good. -Chris. Joseph D. Darcy wrote: Hello. Please review this simple change to replace several calls to val.length() with an already cached copy of val.length(); patch below. 6897550 BigInteger constructor should use local cached String length http://cr.openjdk.java.net/~

Code review request for 6897550 BigInteger constructor should use local cached String length

2009-11-03 Thread Joseph D. Darcy
Hello. Please review this simple change to replace several calls to val.length() with an already cached copy of val.length(); patch below. 6897550 BigInteger constructor should use local cached String length http://cr.openjdk.java.net/~darcy/6897550.0/ -Joe --- old/src/share/classes/java/mat

Re: Code review request for 6897550 BigInteger constructor should use local cached String length

2009-11-03 Thread Andrew John Hughes
2009/11/3 Joseph D. Darcy : > Hello. > > Please review this simple change to replace several calls to val.length() > with an already cached copy of val.length(); patch below. > > 6897550 BigInteger constructor should use local cached String length > http://cr.openjdk.java.net/~darcy/6897550.0/ > >