Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-02-11 Thread Steven Schlansker
On Feb 11, 2013, at 9:04 PM, Mike Duigou wrote: > I have been following up on this issue. I am going to have to adapt the code > a bit because there have been some changes in JDK8. > > I won't forget this issue though. It is possible I may not have time to > backport it to Java 7. > Please l

Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-02-11 Thread Mike Duigou
I have been following up on this issue. I am going to have to adapt the code a bit because there have been some changes in JDK8. I won't forget this issue though. It is possible I may not have time to backport it to Java 7. Mile On Feb 3 2013, at 21:26 , Steven Schlansker wrote: > > On Feb 1

Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-02-03 Thread Mike Duigou
This looks fairly much complete to me. I will run it through the some testing here and then push your patch. Great work and thank you! Mike On Feb 3 2013, at 21:26 , Steven Schlansker wrote: > > On Feb 1, 2013, at 11:42 AM, Mike Duigou wrote: >> >> I have created another issue 8007398 for t

Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-02-03 Thread Steven Schlansker
On Feb 1, 2013, at 11:42 AM, Mike Duigou wrote: > > I have created another issue 8007398 for the changes to Long. We can even > test and push the two issues at the same time. Separating them into two > changesets makes the intent easier to follow for future maintainers. > > We can use the sam

Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-02-01 Thread Mike Duigou
On Feb 1 2013, at 10:13 , Steven Schlansker wrote: > > On Jan 30, 2013, at 11:42 AM, Mike Duigou wrote: > >> Good work Steven! > > Thanks for the review :) >> >> Some initial comments; >> >> - The changes to Long should be in a separate issue. It's generally >> encouraged for changesets t

Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-02-01 Thread Steven Schlansker
On Jan 30, 2013, at 11:42 AM, Mike Duigou wrote: > Good work Steven! Thanks for the review :) > > Some initial comments; > > - The changes to Long should be in a separate issue. It's generally > encouraged for changesets to focus on only one change. Sorry, yes, it's > additional overhead.

Re: RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-30 Thread Mike Duigou
Good work Steven! Some initial comments; - The changes to Long should be in a separate issue. It's generally encouraged for changesets to focus on only one change. Sorry, yes, it's additional overhead. - I would like to see if performed of toString() can be improved further by using String(c

RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-28 Thread Steven Schlansker
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006627 I have created a patch that dramatically improves UUID to/from string performance. Please find below a webrev with my proposed changes. Thanks in advance for any feedback on the contents. I do not believe I have a committer lined up yet.

Re: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-28 Thread Steven Schlansker
; review on this list, clearly stating the subject, and the CR. I had > submitted CR for this change (8006627), it will be eventually available > in public [2]. So, for reviews, you should use this subject line: > "RFR (S) CR 8006627: Improving performance and reducing object > alloca

Re: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-21 Thread Aleksey Shipilev
), it will be eventually available in public [2]. So, for reviews, you should use this subject line: "RFR (S) CR 8006627: Improving performance and reducing object allocations of java.util.UUID to/from string" c) Work with sponsors to commit this. Thanks, -Aleksey. [1] "ksh mak

Re: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-21 Thread Aleksey Shipilev
On 01/20/2013 04:54 AM, Steven Schlansker wrote: >> a) Do you need the masks before or-ing with most/leastSigBits? > > So, they seem to exist to satisfy a few Apache Harmony test cases: > http://svn.apache.org/viewvc/harmony/enhanced/java/branches/java6/classlib/modules/luni/src/test/api/common/or

Re: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-19 Thread Steven Schlansker
Thank you for the feedback! On Jan 10, 2013, at 4:50 AM, Aleksey Shipilev wrote: > On 01/09/2013 09:51 PM, Steven Schlansker wrote: >> Hello again, >> >> I sent this email a week ago and have received no replies. Is there >> any step I have missed necessary to contribute to the JDK libraries?

Re: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-10 Thread Mike Duigou
I apologize for the lack of reply. I had missed this thread while on holiday. As Aleksey suggests the first step is to complete the OCA/CLA. Until that step is complete we won't be able to act upon this contribution in any formal way. I encourage you to update the patch with any specific feedbac

Re: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-10 Thread Aleksey Shipilev
On 01/09/2013 09:51 PM, Steven Schlansker wrote: > Hello again, > > I sent this email a week ago and have received no replies. Is there > any step I have missed necessary to contribute to the JDK libraries? I think the crucial part is OCA, as per: http://openjdk.java.net/contribute/ > I am ver

Re: Improving performance and reducing object allocations of java.util.UUID to/from string

2013-01-09 Thread Steven Schlansker
Hello again, I sent this email a week ago and have received no replies. Is there any step I have missed necessary to contribute to the JDK libraries? I am very interested in making your lives easier, so please let me know if I am in the wrong place or are otherwise misguided. Thanks! Steven

Improving performance and reducing object allocations of java.util.UUID to/from string

2012-12-29 Thread Steven Schlansker
Hello core-libs-dev, My company uses UUIDs throughout our software. We recently identified that the java.util.UUID implementations of fromString and toString are horridly inefficient. An incomplete list of the inefficiencies: * fromString uses a regular expression that is not even precompiled