Changeset: a8f51c3341a5
Author:emc
Date: 2013-07-03 19:47 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a8f51c3341a5
8016285: Add java.lang.reflect.Parameter.isNamePresent()
Summary: Add isNamePresent method to parameter reflection library, which
indicates whether or real p
We generally don't delve into low-level presentation details, but the
change looks fine -- approved to go back.
Cheers,
-Joe
On 7/1/2013 8:04 AM, Eric McCorkle wrote:
Pinging this one again...
On 06/24/13 15:20, Eric McCorkle wrote:
Pinging this RFR. It still needs a capital R reviewer.
ht
Pinging this one again...
On 06/24/13 15:20, Eric McCorkle wrote:
> Pinging this RFR. It still needs a capital R reviewer.
> http://cr.openjdk.java.net/~emc/8016285/
>
> On 06/21/13 19:21, Eric McCorkle wrote:
>> On 06/21/13 16:15, Aleksey Shipilev wrote:
>>> On 06/21/2013 11:57 PM, Eric McCorkl
Can I get a capital-R review on this so I can put it through?
On 06/24/13 17:28, Aleksey Shipilev wrote:
> Forgot to reply: I'm ok with webrev.01.
>
> -Aleksey
> (rural r reviewer)
>
> On 06/24/2013 11:20 PM, Eric McCorkle wrote:
>> Pinging this RFR. It still needs a capital R reviewer.
>> http
Forgot to reply: I'm ok with webrev.01.
-Aleksey
(rural r reviewer)
On 06/24/2013 11:20 PM, Eric McCorkle wrote:
> Pinging this RFR. It still needs a capital R reviewer.
> http://cr.openjdk.java.net/~emc/8016285/
>
> On 06/21/13 19:21, Eric McCorkle wrote:
>> On 06/21/13 16:15, Aleksey Shipilev
Pinging this RFR. It still needs a capital R reviewer.
http://cr.openjdk.java.net/~emc/8016285/
On 06/21/13 19:21, Eric McCorkle wrote:
> On 06/21/13 16:15, Aleksey Shipilev wrote:
>> On 06/21/2013 11:57 PM, Eric McCorkle wrote:
>>> The webrev is here:
>>> http://cr.openjdk.java.net/~emc/8016285/
On 06/21/13 16:15, Aleksey Shipilev wrote:
> On 06/21/2013 11:57 PM, Eric McCorkle wrote:
>> The webrev is here:
>> http://cr.openjdk.java.net/~emc/8016285/
>
> Looks generally good (but not a Reviewer).
>
> A few questions though:
> a) Are we em-bracing the brace-less control flow blocks?
Fix
On 06/21/2013 11:57 PM, Eric McCorkle wrote:
> The webrev is here:
> http://cr.openjdk.java.net/~emc/8016285/
Looks generally good (but not a Reviewer).
A few questions though:
a) Are we em-bracing the brace-less control flow blocks?
b) Should hasRealParameterData be transient?
c) Should ha
Hello, please review this patch which adds isNamePresent to the
java.lang.reflect.Parameter API.
The webrev is here:
http://cr.openjdk.java.net/~emc/8016285/
The change request is here:
http://bugs.sun.com/view_bug.do?bug_id=8016285
The updated spec is here:
http://cr.openjdk.java.net/~abuckley/
