Re: JDK-8196298: Add null Reader and Writer

2018-02-01 Thread Brian Burkhalter
On Feb 1, 2018, at 2:49 PM, Patrick Reinhart wrote: >> Am 01.02.2018 um 22:26 schrieb Brian Burkhalter >> : >>> […] >> >> Yes: there is no such lock instance variable for those classes. Probably it >> would not hurt to add a one liner to each

Re: JDK-8196298: Add null Reader and Writer

2018-02-01 Thread Patrick Reinhart
> Am 01.02.2018 um 22:26 schrieb Brian Burkhalter : > > > On Jan 30, 2018, at 8:52 AM, Patrick Reinhart > wrote: > >>> Am 30.01.2018 um 16:02 schrieb Alan Bateman >>

Re: JDK-8196298: Add null Reader and Writer

2018-02-01 Thread Brian Burkhalter
On Jan 30, 2018, at 8:52 AM, Patrick Reinhart wrote: >> Am 30.01.2018 um 16:02 schrieb Alan Bateman : >> >> […] >> >> One other micro detail is that Reader/Writer support implementations >> specifying the object to use for synchronization. This

Re: JDK-8196298: Add null Reader and Writer

2018-01-30 Thread Patrick Reinhart
> Am 30.01.2018 um 16:02 schrieb Alan Bateman : > > On 29/01/2018 22:55, Brian Burkhalter wrote: >> I made a few minor changes to the CSR [1] verbiage. Probably the >> nullWriter() documentation should also be updated to explicitly mention all >> variants of both

Re: JDK-8196298: Add null Reader and Writer

2018-01-30 Thread Alan Bateman
On 29/01/2018 22:55, Brian Burkhalter wrote: I made a few minor changes to the CSR [1] verbiage. Probably the nullWriter() documentation should also be updated to explicitly mention all variants of both append() and write(). It could although limiting it to the abstract methods should be fine

Re: JDK-8196298: Add null Reader and Writer

2018-01-29 Thread Brian Burkhalter
I made a few minor changes to the CSR [1] verbiage. Probably the nullWriter() documentation should also be updated to explicitly mention all variants of both append() and write(). Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8196350 On Jan 29, 2018, at 12:58 PM, Brian

Re: JDK-8196298: Add null Reader and Writer

2018-01-29 Thread Brian Burkhalter
Great - thanks - will take a look. Brian On Jan 29, 2018, at 11:43 AM, Patrick Reinhart wrote: > Just added a new CSR for it based on the one for InputStream/OutputStream...

Re: JDK-8196298: Add null Reader and Writer

2018-01-29 Thread Patrick Reinhart
Just added a new CSR for it based on the one for InputStream/OutputStream... -Patrick Am 29.01.2018 um 17:14 schrieb Brian Burkhalter: > Hi Patrick, > > Conceptually this looks good. There might be some javadoc tweaks > needed but those can be worked out while this is a draft CSR (to be >

JDK-8196298: Add null Reader and Writer

2018-01-29 Thread Claudia Reinhart
Hi there, I saw that great extension on InputStream/OutputStream adding a Null implementation there. Based on those I would propose a similar addition to the Reader/Writer. -Patrick Here is what the API would look like based on the existing from InputStream/OutputStream:     /** *

Re: JDK-8196298: Add null Reader and Writer

2018-01-29 Thread Brian Burkhalter
Hi Patrick, Conceptually this looks good. There might be some javadoc tweaks needed but those can be worked out while this is a draft CSR (to be filed). Thanks, Brian On Jan 27, 2018, at 12:45 AM, Patrick Reinhart wrote: > I saw that great extension on

JDK-8196298: Add null Reader and Writer

2018-01-27 Thread Patrick Reinhart
Hi there, I saw that great extension on InputStream/OutputStream adding a Null implementation there. Based on those I would propose a similar addition to the Reader/Writer. -Patrick Here is what the API would look like based on the existing from InputStream/OutputStream:     /** *