riginal Message-
From: Kumar Srinivasan
Sent: December 12, 2019 8:32 AM
To: Henry Jen
Cc: core-libs-dev@openjdk.java.net; Nikola Grcevski
Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
Hi Henry,
I approve this. Appreciate you pushing it, as usual *all* possible tests need
to be
LASS --help
>> +// We should be able to find the argument --help as an application
>> argument
>> +ProcessTools.executeProcess(
>> +createProcessWithLauncherDebugging(
>> +"--module-path=" + dir,
>> +
S_WINDOWS) {
>> +return;
>> +}
>> +
>> +String dir = MODS_DIR.toString();
>> +String mid = TEST_MODULE + "/" + MAIN_CLASS;
>> +
>> + // java --module-path=mods --module=$TESTMODULE/$MAINCLASS --help
>> +
SRC_DIR.resolve(TEST_MODULE).toString() + "\\*.java",
> +"--help"))
> + .outputTo(System.out)
> +.errorTo(System.out)
> +.shouldContain("F--help")
> +.shouldContain(&quo
t; + dir,
> +"--module=" + mid,
> +SRC_DIR.resolve(TEST_MODULE).toString() + "\\*.java",
> +"--help"))
> + .outputTo(System.out)
> +.errorTo(System.out)
> +.shouldContain(&q
// deemed as application arguments
+OutputAnalyzer output = ProcessTools.executeProcess(
+createProcessWithLauncherDebugging(
+ "--module-path=" + dir,
+"--module=" + mid,
+"--module-path=" + dir,
+
teProcess(
> +createProcessWithLauncherDebugging(
> +"--module-path=" + dir,
> +"--module=" + mid,
> +SRC_DIR.resolve(TEST_MODULE).toString() + "\\*.java",
> +"--help"))
&
he VM arguments processing. The
second pair of module-path and module will be
+// deemed as application arguments
+OutputAnalyzer output = ProcessTools.executeProcess(
+ createProcessWithLauncherDebugging(
+"--module-path=" + dir,
+&qu
ods --module=$TESTMODULE/$MAINCLASS
> > +// The first --module= will terminate the VM arguments
> processing. The second pair of module-path and module will be
> > + // deemed as application arguments
> > +OutputAnalyzer output = ProcessTools.executeProcess(
"--module-path=" + dir,
> +"--module=" + mid,
> +"--module-path=" + dir,
> +"--module=" + mid))
> +.outputTo(System.out)
> +.errorTo(System.out)
> +.shouldCon
// This command line will not work as --module= is terminating and the
module will be not found
+int exitValue = exec("--module=" + mid, "--module-path" + dir);
+assertTrue(exitValue != 0);
+}
}
-Original Message-
From: Henry Jen
Sent: Decem
th this module usage.
>
> Thank you,
> Nikola
>
> -Original Message-
> From: Henry Jen
> Sent: December 4, 2019 8:26 PM
> To: Kumar Srinivasan ; Alan Bateman
> ; Nikola Grcevski
> Cc: core-libs-dev@openjdk.java.net
> Subject: Re: [EXTERNAL] JDK-8234076 bug fi
dows with this module usage.
Thank you,
Nikola
-Original Message-
From: Henry Jen
Sent: December 4, 2019 8:26 PM
To: Kumar Srinivasan ; Alan Bateman
; Nikola Grcevski
Cc: core-libs-dev@openjdk.java.net
Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
> On Dec 4, 2019, at 1:1
-Original Message-
> From: Henry Jen
> Sent: December 3, 2019 11:39 AM
> To: Kumar Srinivasan
> Cc: Nikola Grcevski ; Alan Bateman
> ; core-libs-dev@openjdk.java.net
> Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
>
> Kumar,
>
> Great to have you look at
-
> From: Henry Jen
> Sent: December 3, 2019 11:39 AM
> To: Kumar Srinivasan
> Cc: Nikola Grcevski ; Alan Bateman <
> alan.bate...@oracle.com>; core-libs-dev@openjdk.java.net
> Subject: Re: [EXTERNAL] JDK-8234076 bug fix candidate
>
> Kumar,
>
> Great to have you
-8234076 bug fix candidate
Kumar,
Great to have you look at this, you are correct, this patch doesn’t address the
wildcard expansion issue, but only to address the potential crash if a main
class is not specified as Nikola pointed out.
We definitely need a follow up to fix wildcard expansion
any comments or suggestions.
>
> Thanks again!
>
> -----Original Message-
> From: Henry Jen
> Sent: December 2, 2019 12:26 PM
> To: Alan Bateman
> Cc: Nikola Grcevski ;
> core-libs-dev@openjdk.java.net
> Subject: [EXTERNAL] Re: JDK-8234076 bug fix candidate
>
>
To: Nikola Grcevski
Cc: Henry Jen ; Alan Bateman ;
core-libs-dev@openjdk.java.net
Subject: Re: [EXTERNAL] Re: JDK-8234076 bug fix candidate
Hi,
Sorry for chiming in late in the review process, for what it's worth
1. It is not at all clear to me if this solution is correct, yes it avert
if you have any comments or suggestions.
>
> Thanks again!
>
> -Original Message-
> From: Henry Jen
> Sent: December 2, 2019 12:26 PM
> To: Alan Bateman
> Cc: Nikola Grcevski ;
> core-libs-dev@openjdk.java.net
> Subject: [EXTERNAL] Re: JDK-8234076 bug fix ca
12:26 PM
To: Alan Bateman
Cc: Nikola Grcevski ;
core-libs-dev@openjdk.java.net
Subject: [EXTERNAL] Re: JDK-8234076 bug fix candidate
The fix looks reasonable to me, basically, if the command argument format is
not legal, it’s possible we won’t find the main class when doing argument file
expa
The fix looks reasonable to me, basically, if the command argument format is
not legal, it’s possible we won’t find the main class when doing argument file
expansion, and the index is -1 which could cause crash on Windows platform for
the wildcard processing.
I think we should add a test case f
On 20/11/2019 19:42, Nikola Grcevski wrote:
:
Please let me know if this approach is acceptable for the current bug report
and I'll make a webrev and include appropriate launcher tests. I was thinking
the tests should do extra validation on the output from _JAVA_LAUNCHER_DEBUG on
Windows.
I
Hello core-libs-dev,
I'm a VM engineer at Microsoft and new to this mailing list. I took a look at
JDK- 8234076 and the root cause is similar to a prior thread on a Windows
launcher bug for JDK- 8231863, after the command line arguments are processed,
the static variable firstAppArgIndex in
sr
23 matches
Mail list logo
