Re: JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Joe Darcy
Hi Kumar, On 06/30/2013 04:45 PM, Kumar Srinivasan wrote: Hi Joe, The changes looks good, thanks for doing this!. I should've peeked at the generated reports. :-[ The changes look fine according to specdiff too. But, there are 2 more errors j.u.j.Attributes.java and some missing @throws fo

Re: JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Kumar Srinivasan
Hi Joe, The changes looks good, thanks for doing this!. I should've peeked at the generated reports. :-[ But, there are 2 more errors j.u.j.Attributes.java and some missing @throws for j.u.j.JarEntry.java, are you planning on doing this separately ? Thanks Kumar Hello, Pack200 has some doc

Re: JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Lance Andersen - Oracle
looks good Joe On Jun 30, 2013, at 7:20 PM, Joe Darcy wrote: > Hello, > > Pack200 has some doclint issues; please review the fixes to them below. > > Thanks, > > -Joe > > --- a/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:02:11 > 2013 -0700 > +++ b/src/share/classes/java/util

JDK 8 code review request for doclint fixes in java.util.jar.Pack200

2013-06-30 Thread Joe Darcy
Hello, Pack200 has some doclint issues; please review the fixes to them below. Thanks, -Joe --- a/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:02:11 2013 -0700 +++ b/src/share/classes/java/util/jar/Pack200.javaSun Jun 30 16:19:25 2013 -0700 @@ -1,5 +1,5 @@ /* - * Copyr