Re: JDK 9 RFR of 8150206: Demote LFMultiThreadCachingTest.java to tier 2 until resolution of JDK-8150014

2016-02-20 Thread Martin Buchholz
On Fri, Feb 19, 2016 at 1:37 PM, Martin Buchholz wrote: > I will commit by Monday. Pushed. > The only other change I'm thinking of would be to move the Unsafe > initialization to the top of file (i.e. beginning of ) instead > of bottom of file where we've traditionally placed it. Here a static

Re: JDK 9 RFR of 8150206: Demote LFMultiThreadCachingTest.java to tier 2 until resolution of JDK-8150014

2016-02-19 Thread Martin Buchholz
I will commit by Monday. The only other change I'm thinking of would be to move the Unsafe initialization to the top of file (i.e. beginning of ) instead of bottom of file where we've traditionally placed it. Here a static method call that used U found it to be null - we must still be inside , eh

Re: JDK 9 RFR of 8150206: Demote LFMultiThreadCachingTest.java to tier 2 until resolution of JDK-8150014

2016-02-19 Thread joe darcy
Hello, I'm happy if Martin's delambdafication is the right solution. However, if that is not pushed by Monday Feb. 22, I'll want to go ahead and problem list the test. Thanks, -Joe On 2/19/2016 1:40 AM, Paul Sandoz wrote: Hi Martin, Your patch to TLR and SR looks good: http://cr.open

Re: JDK 9 RFR of 8150206: Demote LFMultiThreadCachingTest.java to tier 2 until resolution of JDK-8150014

2016-02-19 Thread Paul Sandoz
Hi Martin, Your patch to TLR and SR looks good: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jsr166-jdk9-integration/unlambdafyBootstrap/jsr166-jdk9-integration- Sorry, i should of caught this in review, did notice the change to use lambdas but i forgot that this might cause issues at

Re: JDK 9 RFR of 8150206: Demote LFMultiThreadCachingTest.java to tier 2 until resolution of JDK-8150014

2016-02-18 Thread joe darcy
Hi Martin, On 2/18/2016 10:18 PM, Martin Buchholz wrote: It's easy enough to get the test to pass by delambdafication. But we may not want to fix the test because it's not clear whether it's a jdk lambda bug or not, and we don't sweep bugs under the rug. Maybe instead of a "tier2" bucket we re

Re: JDK 9 RFR of 8150206: Demote LFMultiThreadCachingTest.java to tier 2 until resolution of JDK-8150014

2016-02-18 Thread Martin Buchholz
It's easy enough to get the test to pass by delambdafication. But we may not want to fix the test because it's not clear whether it's a jdk lambda bug or not, and we don't sweep bugs under the rug. Maybe instead of a "tier2" bucket we really want a "test found a bug that's not yet fixed" bucket?

JDK 9 RFR of 8150206: Demote LFMultiThreadCachingTest.java to tier 2 until resolution of JDK-8150014

2016-02-18 Thread joe darcy
Hello, Right now, we are seeing some cross-platform intermittent failures of java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java as noted in bug JDK-8150014. Until that test instability is resolved, the test should be demoted from tier 1 to tier 2. Please see the patch below. (Circ