Hi Joe,
These changes are fine. You might want to update the copyright year of
ExceptionProxy.java though.
s'marks
On 3/3/14 10:05 PM, Joe Darcy wrote:
Hi Stuart,
Thanks for the careful review. I agree the case of TreeMap.NavigableSbugMap
requires some more investigation. In the meantime,
Hi Stuart,
Thanks for the careful review. I agree the case of
TreeMap.NavigableSbugMap requires some more investigation. In the
meantime, I'd like to proceed with the revised patch below for EnumSet
and ExceptionProxy.
Thanks,
-Joe
diff -r 6cfedc362f48
On 2/27/14 12:11 PM, Joe Darcy wrote:
I am trying hard to remain blissfully ignorant of any more low-level details of
the serialization format; however, I might not be successful on that goal much
longer ;-)
I believe your latter statement is correct. :-)
My preference in a case like this is
On 02/24/2014 10:53 PM, Stuart Marks wrote:
On 2/24/14 8:22 PM, Joe Darcy wrote:
On 02/20/2014 12:49 PM, Paul Benedict wrote:
Joe, I find it interesting that you suppressed the serial warning on an
abstract class. I'd like to know more about that. Is this a
universal rule?
Are serial uids
Hi Martin,
Yes, um, I agree. :-) Perhaps theere is some hope here:
http://openjdk.java.net/jeps/187
Which of course will avoid all the mistakes in the first version of
serialization. That will create room for bigger and better mistakes. :-)
And then of course there is this:
Hi Paul,
On 02/20/2014 12:49 PM, Paul Benedict wrote:
Joe, I find it interesting that you suppressed the serial warning on
an abstract class. I'd like to know more about that. Is this a
universal rule? Are serial uids not important for abstract classes?
I wouldn't generalize that way from
On 2/24/14 8:22 PM, Joe Darcy wrote:
On 02/20/2014 12:49 PM, Paul Benedict wrote:
Joe, I find it interesting that you suppressed the serial warning on an
abstract class. I'd like to know more about that. Is this a universal rule?
Are serial uids not important for abstract classes?
I wouldn't
Hello,
Please review the patch below which will address the handful of
remaining serial lint warning in the core libraries.
Thanks,
-Joe
diff -r e5a09bc70308 src/share/classes/java/util/EnumSet.java
--- a/src/share/classes/java/util/EnumSet.javaThu Feb 20 13:03:36
2014 +
+++
Joe, I find it interesting that you suppressed the serial warning on an
abstract class. I'd like to know more about that. Is this a universal rule?
Are serial uids not important for abstract classes?
On Thu, Feb 20, 2014 at 2:33 PM, Joe Darcy joe.da...@oracle.com wrote:
Hello,
Please review
