JDK 9 RFR of adding missing javadoc to javax.transaction

2015-04-16 Thread joe darcy
Hello, While preparing to turn on doclint build warnings on more modules, I noticed there are missing javadoc comments on various classes in javax.transaction. Please review the patch below which add in some obvious javadoc. Thanks, -Joe diff -r 488af0e8ee33

Re: JDK 9 RFR of adding missing javadoc to javax.transaction

2015-04-16 Thread Roger Riggs
Hi Joe, Looks fine. Roger On 4/16/2015 2:08 PM, joe darcy wrote: Hello, While preparing to turn on doclint build warnings on more modules, I noticed there are missing javadoc comments on various classes in javax.transaction. Please review the patch below which add in some obvious

Re: JDK 9 RFR of adding missing javadoc to javax.transaction

2015-04-16 Thread Lance Andersen
Hi Joe, This Looks OK. I have already had discussions with the Java EE leads about adding the SUID and pushing the changes back upstream (and updating other classes in upstream javax.transaction as needed. I will be doing that soon and will push these changes as well. Best, Lance On Apr

Re: JDK 9 RFR of adding missing javadoc to javax.transaction

2015-04-16 Thread joe darcy
Hi Lance, On 4/16/2015 11:27 AM, Lance Andersen wrote: Hi Joe, This Looks OK. I have already had discussions with the Java EE leads about adding the SUID and pushing the changes back upstream (and updating other classes in upstream javax.transaction as needed. I will be doing that soon

Re: JDK 9 RFR of adding missing javadoc to javax.transaction

2015-04-16 Thread Alan Bateman
This looks okay but I think we should get Lance to check the EE folks because this area has a standalone JSR. It came up a few months too with the SUID and I think Lance is following up with them on that too. -Alan On 16/04/2015 19:08, joe darcy wrote: Hello, While preparing to turn on