Re: MethodParameters class file format change

2013-01-28 Thread Eric McCorkle
On 01/26/13 02:52, David Holmes wrote: There must already be tests for this new feature else you would be pushing untested code, so you would break these tests while your changes sync up. Tests do exist, but they are presently disabled. The end-to-end tests were part of JDK-8004729, which

Re: MethodParameters class file format change

2013-01-28 Thread John Rose
On Jan 26, 2013, at 4:50 AM, Chris Hegarty wrote: To be clear I'm not saying this can't happen. I'm just saying that the right people need to ensure that all the necessary pieces are in place, and the procedures established before we actually start doing it on a regular basis. Yes, I

Re: MethodParameters class file format change

2013-01-26 Thread Chris Hegarty
David, As you know, recently we have seen jdk changes coming in from the hotspot integration forests, thus potentially avoiding a flag day. I'm not saying that this is necessarily a good idea, but just wondering if it is now something that we should reconsider, over the hefty process you

Re: MethodParameters class file format change

2013-01-26 Thread David Holmes
Hi Chris, On 26/01/2013 6:22 PM, Chris Hegarty wrote: David, As you know, recently we have seen jdk changes coming in from the hotspot integration forests, thus potentially avoiding a flag day. I'm not saying that this is necessarily a good idea, but just wondering if it is now something that

Re: MethodParameters class file format change

2013-01-26 Thread David Holmes
On 26/01/2013 10:36 PM, David Holmes wrote: Hi Chris, On 26/01/2013 6:22 PM, Chris Hegarty wrote: David, As you know, recently we have seen jdk changes coming in from the hotspot integration forests, thus potentially avoiding a flag day. I'm not saying that this is necessarily a good idea,

MethodParameters class file format change

2013-01-25 Thread Eric McCorkle
I don't think anyone is using MethodParameters at this point, but I want to post this just to be sure. The latest version of the spec alters the class file format of MethodParameters attributes. The latest version can be found here: http://cr.openjdk.java.net/~abuckley/8misc.pdf I will be

Re: MethodParameters class file format change

2013-01-25 Thread David Holmes
Eric, These situations are historically known as Flag Days and they require careful management. I don't know exactly what has to be done but the way to approach this is to modify the VM to be prepared to handle both the old format and the new. Then after it has reached TL/jdklangtools