RE: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Appreciate all your kind help in making it happen. Regards Patrick From: Roger Riggs Sent: Tuesday, January 22, 2019 10:56 PM To: David Holmes ; Patrick Zhang Cc: core-libs-dev Subject: Re: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot

Re: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi David, Thanks for running the tests. Pushed. Thanks, Roger On 01/22/2019 01:45 AM, David Holmes wrote: Mach 5 tier 1 - 3 tests passed on Linux/OS X/Windows x64 and Solaris sparcv9. David On 22/01/2019 2:01 pm, David Holmes wrote: Hi Patrick, I'm putting this through our test system

Re: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Mach 5 tier 1 - 3 tests passed on Linux/OS X/Windows x64 and Solaris sparcv9. David On 22/01/2019 2:01 pm, David Holmes wrote: Hi Patrick, I'm putting this through our test system (again) and will report back when its complete. I also updated the bug report with the patch and assigned to

Re: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi Patrick, I'm putting this through our test system (again) and will report back when its complete. I also updated the bug report with the patch and assigned to Roger as the sponsor. Cheers, David On 22/01/2019 12:21 pm, Patrick Zhang wrote: Thanks Roger. I did a try to push the patch

RE: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Thanks Roger. I did a try to push the patch within a branch to jdk/submit, and saw “Permission denied (publickey)”. I sent my SSH pub key to keys(at)openjdk.java.net but got no response. I heard only committers can have the access right, could you please help? Regards Patrick From: Roger

Re: 8215976: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi, I can sponsor this. Let me know when the jdk-submit is complete. Thanks, Roger On 01/16/2019 10:03 AM, Alan Bateman wrote: On 16/01/2019 02:30, Patrick Zhang wrote: Looks .patch didn't work as an attachment, retry with .txt and paste the text below as well. Sorry for one more message

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

On 16/01/2019 02:30, Patrick Zhang wrote: Looks .patch didn't work as an attachment, retry with .txt and paste the text below as well. Sorry for one more message here. I think this patch looks okay and I assume you'll test it in the jdk-submit repo to make sure it builds on all platforms.

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Looks .patch didn't work as an attachment, retry with .txt and paste the text below as well. Sorry for one more message here. # HG changeset patch # User patrickz # Date 1546508379 -28800 # Thu Jan 03 17:39:39 2019 +0800 # Node ID 0a90eb1de8e4e6c87a6643072e00645d5dde9da2 # Parent

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Re-generated the patch in pure text using “hg export -o” instead of webrev, perhaps this could work (see attached please). Comments had been updated as well according to David’s input. Thanks Regards Patrick From: Roger Riggs Sent: Tuesday, January 15, 2019 11:26 PM To: Patrick Zhang Cc:

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi Patrick, Attaching just the patch file that is text works fine and it can be applied directly using patch. I don't find a patch in your emails that I can apply directly (or am using the wrong tool). The allowed attachment types are occasionally mentioned.  [1] Thanks, Roger [1]

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi Patrick, On 15/01/2019 7:24 pm, Patrick Zhang wrote: In case the attachment may get dropped by mailing system, I paste the udiffs in text here. Yes attachments are generally dropped. ./src/jdk.pack/share/native/common-unpack/zip.cpp rev

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

In case the attachment may get dropped by mailing system, I paste the udiffs in text here. ./src/jdk.pack/share/native/common-unpack/zip.cpp rev 53300 : 8215976: Fix gmtime_r declaration

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi Roger, Thanks for your review firstly. Attached is the latest patch rebased on today's tip of jdk/jdk (http://hg.openjdk.java.net/jdk/jdk/rev/0b2574a2a6c7). <> Yes there is a "#ifndef _MSC_VER" at line 36, while I think we'd better keep this "#ifdef _MSC_VER" here, as such the declaration

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi Patrick, Please re-post the entire proposed patch based on the JDK 13 repo. BTW, there is already a "#ifndef _MSC_VER" at line 36. Thanks, Roger On 01/14/2019 09:02 AM, Magnus Ihse Bursie wrote: On 2019-01-02 00:11, David Holmes wrote: Hi Patrick, On 13/12/2018 1:23 pm, Patrick Zhang

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

On 2019-01-02 00:11, David Holmes wrote: Hi Patrick, On 13/12/2018 1:23 pm, Patrick Zhang wrote: Ping... Apply for a sponsor for this simple patch. Seems no one wants to own this one :( For what it's worth, it looks good to me. (But I'd like to see a core library developer chime in as

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Thank you very much, David, for helping file the bug in system. Hi, Core Libraries Group, I am not quite clear who owns jdk.pack/share/native/common-unpack/zip.cpp (at jdk/jdk for example). Could anyone please help? The issue covered in this thread is a simple but a generic concern to all

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi Patrick, On 13/12/2018 1:23 pm, Patrick Zhang wrote: Ping... Apply for a sponsor for this simple patch. Seems no one wants to own this one :( I doubt if I could have permission to file the issue/bug report anywhere, could anyone kindly give a guidance? Thanks. I have filed:

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Ping... Apply for a sponsor for this simple patch. I doubt if I could have permission to file the issue/bug report anywhere, could anyone kindly give a guidance? Thanks. Regards Patrick -Original Message- From: core-libs-dev On Behalf Of Patrick Zhang Sent: Thursday, December 6,

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

To All, Who could help sponsor this simple patch (may require a wide range of building tests)? Thanks in advance. Regards Patrick -Original Message- From: David Holmes Sent: Monday, December 3, 2018 8:11 AM To: Patrick Zhang ; Florian Weimer Cc: core-libs-dev@openjdk.java.net

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Hi Patrick, On 30/11/2018 11:41 pm, Patrick Zhang wrote: Thanks Florian, the "-isystem /usr/include" is helpful to my case, I see gcc.gnu.org says that "it gets the same special treatment that is applied to the standard system directories". As such the issue gets hidden (error suppressed).

RE: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

Thanks Florian, the "-isystem /usr/include" is helpful to my case, I see gcc.gnu.org says that "it gets the same special treatment that is applied to the standard system directories". As such the issue gets hidden (error suppressed). Hi David, Thanks for your suggestion. My intention was to

Re: OpenJDK fails to build with GCC when the #include inside zip.cpp comes from a non-sysroot path

* David Holmes: > This should really be being discussed on core-libs-dev. Okay, moving the conversation. >> diff -r 70a423caee44 src/share/native/com/sun/java/util/jar/pack/zip.cpp >> --- a/src/share/native/com/sun/java/util/jar/pack/zip.cppTue Oct 09 >> 08:33:33 2018 +0100 >> +++