Hello,
Could you please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8138838
Patch + webrev zipped + specdiff report:
http://cr.openjdk.java.net/~avstepan/8138838
Just some cosmetic changes for docs (... -> {@code ...}
replacement) + some misprints fixed.
Not sure if these
Hello Martin, Stuart,
Thank you for the notes,
Yes, the initial utility is quite ugly, I just tried to prepare it as
quickly as possible hoping that it covers the majority of "trivial"
replace cases. Yes, it does not process multi-line inclusions.
> s = s.replace( "", tag1);
> s =
+1 for manageable sized and per repo code-reviews.
(unless someone has a tool that checks the patch to confirm that the
only difference between
the old and the new is the same small number of substitutions; another
quick program perhaps...).
On 10/1/2015 8:40 AM, Lance Andersen wrote:
Hi
Hi Alexander,
Personally, I would find it easier to review if the changes were sent out by
category/module vs one large patch as it is easier to miss things.
Also for technologies such as jaxws, these will need to go to the external
workspace at the same time for the technology so these should
Hello Lance,
Yes, to be honest, I also fear to push at once a single changeset for
jdk touching thousands of files.
Moreover, I'm pretty sure that e.g. java.desktop part should go to a
client repository instead of dev, changes for client and security libs
should be approved by corresponding
Nice try Martin, but I'm not going to get sucked into a round of perl code golf
with you. :-)
I wasn't sure why the absolute path stuff was in there; I just carried it over
from Alexander's code. I'll let Alexander fix this along with your point about
handling multiple files, if he wants to.
Hi s'marks,
You probably don't need to absolutify paths.
And you can easily handle multiple args.
(just for fun!)
Checks for javadoc comment; handles popular html entities; handles multiple
lines; handles both tt and code:
#!/bin/bash
find "$@" -name '*.java' | \
xargs -r perl -p0777i -e \
Hi Alexander, Martin,
The challenge of Perl file slurping and Emacs one-liners was too much to bear.
This is Java, so one-liners are hardly possible. Still, there are a bunch of
improvements that can be made to the Java version. (OK, and I'm showing off a bit.)
Take a look at this:
Updated: a few manual corrections were made (as @linkplain tags displays
nested {@code } literally):
http://cr.openjdk.java.net/~avstepan/tmp/codeTags/jdk.patch
-checked with specdiff (which of course does not cover documentation for
internal packages), no unexpected diffs detected.
Regards,
Hi Alexander,
your change looks good. It's OK to have manual corrections for automated
mega-changes like this, as long as they all revert changes.
Random comments:
Should you publish your specdiff? I guess not - it would be empty!
while((s = br.readLine()) != null) {
by matching
10 matches
Mail list logo
