Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-15 Thread Andrew Hughes
- Original Message - > Yes, you are good to go. > Thanks! Pushed: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/35e024c6a62c > Thanks! > -Sherman > > > On 8/14/2012 6:13 AM, Andrew Hughes wrote: > > - Original Message - > >> On 14/08/2012 13:36, Andrew Hughes wrote: > >>> : > >>>

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Andrew Hughes
- Original Message - > On 14/08/2012 14:13, Andrew Hughes wrote: > > Can I take that as it's good to push? :-D > No objection from me although if the default is changed to > SYSTEM_ZLIB=true for Linux (and maybe Solaris) then it will require > making sure that it builds everywhere without n

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Alan Bateman
On 14/08/2012 14:13, Andrew Hughes wrote: Can I take that as it's good to push? :-D No objection from me although if the default is changed to SYSTEM_ZLIB=true for Linux (and maybe Solaris) then it will require making sure that it builds everywhere without needing other options. -Alan.

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Xueming Shen
Yes, you are good to go. Thanks! -Sherman On 8/14/2012 6:13 AM, Andrew Hughes wrote: - Original Message - On 14/08/2012 13:36, Andrew Hughes wrote: : Do you have a static libz.a installed (from zlib1g-dev) and all dependent static libraries? I think you're right about the static li

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Andrew Hughes
- Original Message - > On 14/08/2012 13:36, Andrew Hughes wrote: > > : > > > > Do you have a static libz.a installed (from zlib1g-dev) and all > > dependent static libraries? > I think you're right about the static linking but this was just a > quick > test to see if SYSTEM_ZLIB=true worked

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Alan Bateman
On 14/08/2012 13:36, Andrew Hughes wrote: : Do you have a static libz.a installed (from zlib1g-dev) and all dependent static libraries? I think you're right about the static linking but this was just a quick test to see if SYSTEM_ZLIB=true worked with everything else as default. pack200 has

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-14 Thread Andrew Hughes
- Original Message - > On 10/08/2012 18:40, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew > >> > >> Alan mentioned the other day that the build (with your latest > >> patch, > >> with zlib-dev) failed at pack200 > >> when he tried to turn it on on linux. Can your doub

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-10 Thread Alan Bateman
On 10/08/2012 18:40, Andrew Hughes wrote: - Original Message - Hi Andrew Alan mentioned the other day that the build (with your latest patch, with zlib-dev) failed at pack200 when he tried to turn it on on linux. Can your double check on your system? What kind of failure? All webrevs

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-10 Thread Andrew Hughes
- Original Message - > Hi Andrew > > Alan mentioned the other day that the build (with your latest patch, > with zlib-dev) failed at pack200 > when he tried to turn it on on linux. Can your double check on your > system? > What kind of failure? All webrevs I've posted pass a complete bu

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-10 Thread Xueming Shen
Hi Andrew Alan mentioned the other day that the build (with your latest patch, with zlib-dev) failed at pack200 when he tried to turn it on on linux. Can your double check on your system? -Sherman On 08/09/2012 06:31 AM, Andrew Hughes wrote: Just checking on the status of this. Am I ok to

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-09 Thread Andrew Hughes
- Original Message - > On 08/06/2012 11:26 AM, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew, > >> > >> I meant if we are going to put SYSTEM_ZLIB=true as default for > >> linux > >> as > >> Alan suggested, > >> we might need to update the build document as well to

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-07 Thread Kumar Srinivasan
Hi, Please make sure that the jdk/test/tools/* tests are run and validated. Both the java launcher and the pack200 tools are dependent on zlib entry points for inflate/deflate and other things. Kumar - Original Message - On 08/06/2012 11:26 AM, Andrew Hughes wrote: - Original Me

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-07 Thread Andrew Hughes
- Original Message - > On 08/06/2012 11:26 AM, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew, > >> > >> I meant if we are going to put SYSTEM_ZLIB=true as default for > >> linux > >> as > >> Alan suggested, > >> we might need to update the build document as well to in

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-06 Thread Xueming Shen
On 08/06/2012 11:26 AM, Andrew Hughes wrote: - Original Message - Hi Andrew, I meant if we are going to put SYSTEM_ZLIB=true as default for linux as Alan suggested, we might need to update the build document as well to include zlib-dev as the "necessary" package to build jdk on linux.

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-06 Thread Andrew Hughes
- Original Message - > Hi Andrew, > > I meant if we are going to put SYSTEM_ZLIB=true as default for linux > as > Alan suggested, > we might need to update the build document as well to include > zlib-dev > as the "necessary" > package to build jdk on linux. Ok. I think that's a separate

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-06 Thread Xueming Shen
Hi Andrew, I meant if we are going to put SYSTEM_ZLIB=true as default for linux as Alan suggested, we might need to update the build document as well to include zlib-dev as the "necessary" package to build jdk on linux. Currently the SYSTEM_ZLIB=true is set in make/common/Defs-macosx.gmk. ZLI

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-06 Thread Andrew Hughes
- Original Message - > > On 8/5/2012 2:00 PM, Alan Bateman wrote: > > On 03/08/2012 19:33, Andrew Hughes wrote: > >> : > >> http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/ > >> > >> is an updated version which checks if ZLIB_LIBS is set on Solaris, > >> GNU/Linux > >> and MacO

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-06 Thread Andrew Hughes
- Original Message - > Andrew, > > I just pushed 7188852. Is it possible for you to update your webrev > with > this change? I would > like to try a full build (and regression tests) on your final bits to > make sure we don't break > the build. > Do you mean the ZLIB_LIBS changes? I alr

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-06 Thread Andrew Hughes
- Original Message - > Andrew, > > I just pushed 7188852. Is it possible for you to update your webrev > with > this change? I would > like to try a full build (and regression tests) on your final bits to > make sure we don't break > the build. > Do you mean the ZLIB_LIBS changes? I alr

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-05 Thread Xueming Shen
On 8/5/2012 2:00 PM, Alan Bateman wrote: On 03/08/2012 19:33, Andrew Hughes wrote: : http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/ is an updated version which checks if ZLIB_LIBS is set on Solaris, GNU/Linux and MacOS X and sets it to -lz if not. I wasn't sure what to do with W

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-05 Thread Alan Bateman
On 03/08/2012 19:33, Andrew Hughes wrote: : http://cr.openjdk.java.net/~andrew/syslibs/zlib/webrev.02/ is an updated version which checks if ZLIB_LIBS is set on Solaris, GNU/Linux and MacOS X and sets it to -lz if not. I wasn't sure what to do with Windows but something can be added there if n

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-03 Thread Xueming Shen
Andrew, I just pushed 7188852. Is it possible for you to update your webrev with this change? I would like to try a full build (and regression tests) on your final bits to make sure we don't break the build. -Sherman On 08/03/2012 11:33 AM, Andrew Hughes wrote: - Original Message -

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-03 Thread Andrew Hughes
- Original Message - > > > - Original Message - > > On 03/08/2012 16:58, Andrew Hughes wrote: > > > > : It's what we've had for years, and was added orthogonally to 8 > > in: > > > > changeset: 5118:d45bc4307996 > > user:michaelm > > date:Tue Mar 06 20:34:38 20

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-03 Thread Andrew Hughes
- Original Message - > On 03/08/2012 16:58, Andrew Hughes wrote: > > : It's what we've had for years, and was added orthogonally to 8 in: > > changeset: 5118:d45bc4307996 > user:michaelm > date:Tue Mar 06 20:34:38 2012 + > summary: 7113349: Initial changeset fo

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-03 Thread Alan Bateman
On 03/08/2012 16:58, Andrew Hughes wrote: : It's what we've had for years, and was added orthogonally to 8 in: changeset: 5118:d45bc4307996 user:michaelm date:Tue Mar 06 20:34:38 2012 + summary: 7113349: Initial changeset for Macosx port to jdk though that version is b

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-03 Thread Andrew Hughes
- Original Message - > On 02/08/2012 19:31, Andrew Hughes wrote: > > : > > > > > > Ok, I thought that's what you were aiming at. That wouldn't solve > > the problem > > for us. We can't include a version of zlib in OpenJDK. It > > violates distribution > > policies and means security upd

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-03 Thread Alan Bateman
On 02/08/2012 19:31, Andrew Hughes wrote: : Ok, I thought that's what you were aiming at. That wouldn't solve the problem for us. We can't include a version of zlib in OpenJDK. It violates distribution policies and means security updates have to be applied in two places. We've been carryi

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-02 Thread Andrew Hughes
- Original Message - > Hi Andrew, > > I do have a ref# for this enhancement #7110151. Though my original > idea > is to also have > a configurable mechanism to switch the zlib usage during the jvm > startup > (-D option for > example). Let's use this one for your patch. I will take a look

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-02 Thread Andrew Hughes
- Original Message - > On 08/02/2012 11:13 AM, Andrew Hughes wrote: > > - Original Message - > >> Hi Andrew, > >> > >> I do have a ref# for this enhancement #7110151. Though my original > >> idea > >> is to also have > >> a configurable mechanism to switch the zlib usage during th

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-02 Thread Xueming Shen
On 08/02/2012 11:13 AM, Andrew Hughes wrote: - Original Message - Hi Andrew, I do have a ref# for this enhancement #7110151. Though my original idea is to also have a configurable mechanism to switch the zlib usage during the jvm startup (-D option for example). Let's use this one for y

Re: PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-02 Thread Xueming Shen
Hi Andrew, I do have a ref# for this enhancement #7110151. Though my original idea is to also have a configurable mechanism to switch the zlib usage during the jvm startup (-D option for example). Let's use this one for your patch. I will take a look your patch this week. -Sherman On 08/02/

PING: [PATCH FOR REVIEW] System Zlib Support

2012-08-02 Thread Andrew Hughes
- Original Message - > Hi all, > > In OpenJDK 8, some support has already been added for using the > system installation of zlib > (see the thread > http://mail.openjdk.java.net/pipermail/core-libs-dev/2012-July/010967.html), > which is very similar to the support we've had in IcedTea for