Re: Patch to expand tz checking scope in TimeZone_md.c

2012-01-09 Thread Jonathan Lu
Hi core-libs-dev, Here's another approach to just add a defined(AIX) check to make sure it works on Aix platform. http://cr.openjdk.java.net/~luchsh/timezone_md_ret_check/ Any suggestions? Cheers, - Jonathan On 11/02/2011 04:56 PM, Jonathan Lu wrote: Hi core-libs-dev, In jdk/src/solaris/na

Re: Patch to expand tz checking scope in TimeZone_md.c

2012-01-03 Thread Kurt Miller
On Monday 14 November 2011 03:40:01 am Jonathan Lu wrote: > Hi Kurt, > > On 11/10/2011 11:09 AM, Kurt Miller wrote: > > On 11/09/11 03:01, Jonathan Lu wrote: > >> On 11/04/2011 01:26 PM, David Holmes wrote: > >>> On 4/11/2011 2:53 PM, David Holmes wrote: > On 4/11/2011 2:13 PM, Masayoshi Okut

Re: Patch to expand tz checking scope in TimeZone_md.c

2012-01-03 Thread Kurt Miller
On 11/09/11 03:01, Jonathan Lu wrote: > On 11/04/2011 01:26 PM, David Holmes wrote: >> On 4/11/2011 2:53 PM, David Holmes wrote: >>> On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and Ubuntu 10.03. The difference still exists. >>

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-14 Thread Jonathan Lu
Hi Kurt, On 11/10/2011 11:09 AM, Kurt Miller wrote: On 11/09/11 03:01, Jonathan Lu wrote: On 11/04/2011 01:26 PM, David Holmes wrote: On 4/11/2011 2:53 PM, David Holmes wrote: On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and Ubunt

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-09 Thread Jonathan Lu
On 11/04/2011 01:26 PM, David Holmes wrote: On 4/11/2011 2:53 PM, David Holmes wrote: On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and Ubuntu 10.03. The difference still exists. Solaris 10: $ unset TZ $ date Fri Nov 4 13:04:45 JST 2

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-03 Thread David Holmes
On 4/11/2011 2:53 PM, David Holmes wrote: On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and Ubuntu 10.03. The difference still exists. Solaris 10: $ unset TZ $ date Fri Nov 4 13:04:45 JST 2011 $ TZ="" date Fri Nov 4 13:04:53 JST 2011

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-03 Thread David Holmes
On 4/11/2011 2:13 PM, Masayoshi Okutsu wrote: Probably the difference isn't documented. I tried Solaris 10 and Ubuntu 10.03. The difference still exists. Solaris 10: $ unset TZ $ date Fri Nov 4 13:04:45 JST 2011 $ TZ="" date Fri Nov 4 13:04:53 JST 2011 Ubuntu 10.04: $ unset TZ $ date Fri Nov 4

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-03 Thread Masayoshi Okutsu
Probably the difference isn't documented. I tried Solaris 10 and Ubuntu 10.03. The difference still exists. Solaris 10: $ unset TZ $ date Fri Nov 4 13:04:45 JST 2011 $ TZ="" date Fri Nov 4 13:04:53 JST 2011 Ubuntu 10.04: $ unset TZ $ date Fri Nov 4 13:05:50 JST 2011 $ TZ="" date Fri Nov 4 0

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-03 Thread Jonathan Lu
Hi Masayoshi, I did find some references about date-time related functions / TZ variables on Linux but got only a few about Solaris, so could not see any differences between those two platforms about the changes described in my patch. Have you got any links or references about these differenc

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-02 Thread Masayoshi Okutsu
Hi Jonathan, IIRC, the difference came from some behavioral difference between the Linux and Solaris libc date-time functions and/or the date command, and TimeZone_md.c tries to follow the difference. But the code was written long ago. The difference may no longer exist. Thanks, Masayosh

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-02 Thread Jonathan Lu
On 11/02/2011 07:00 PM, David Holmes wrote: On 2/11/2011 7:01 PM, Jonathan Lu wrote: On 11/02/2011 04:56 PM, Jonathan Lu wrote: Hi core-libs-dev, In jdk/src/solaris/native/java/util/TimeZone_md.c, starting from line 626, I found that the scope of "#ifdef __solaris__" might be too narrow, since

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-02 Thread David Holmes
On 2/11/2011 7:01 PM, Jonathan Lu wrote: On 11/02/2011 04:56 PM, Jonathan Lu wrote: Hi core-libs-dev, In jdk/src/solaris/native/java/util/TimeZone_md.c, starting from line 626, I found that the scope of "#ifdef __solaris__" might be too narrow, since it also works for some kind of OS which I'm

Re: Patch to expand tz checking scope in TimeZone_md.c

2011-11-02 Thread Jonathan Lu
On 11/02/2011 04:56 PM, Jonathan Lu wrote: Hi core-libs-dev, In jdk/src/solaris/native/java/util/TimeZone_md.c, starting from line 626, I found that the scope of "#ifdef __solaris__" might be too narrow, since it also works for some kind of OS which I'm currently working on, such as AIX. So I

Patch to expand tz checking scope in TimeZone_md.c

2011-11-02 Thread Jonathan Lu
Hi core-libs-dev, In jdk/src/solaris/native/java/util/TimeZone_md.c, starting from line 626, I found that the scope of "#ifdef __solaris__" might be too narrow, since it also works for some kind of OS which I'm currently working on, such as AIX. So I suggest to just remove the '#ifdef __solari