On 10/22/13 2:06 PM, roger riggs wrote:
Hi Mandy,
On 10/22/2013 5:01 PM, Mandy Chung wrote:
The .
is updated to {@code ...} that should simply be:
{@code ...}
the {@code ...} does not imply preformatted. So for a multi-line or
separate line example the is still needed.
That's tru
Hi Mandy,
On 10/22/2013 5:01 PM, Mandy Chung wrote:
The .
is updated to {@code ...} that should simply be:
{@code ...}
the {@code ...} does not imply preformatted. So for a multi-line or
separate line example the is still needed.
I notice that there are few ending not removed in
The .
is updated to {@code ...} that should simply be:
{@code ...}
I notice that there are few ending not removed in this
updated patch. One example:
- *
- * (byte)(0xff & (v >> 8))
- * (byte)(0xff & v)
- *
+ * {@code
+ * (byte)(0xff & (v >> 8))
+ * (byte)(
Looks good.
> The id="xxx" form is equivalent way to tag a paragraph with a target link.
TIL that it's time to stop using wrote:
> Thanks for the comments, updated with Webrev with the suggestions.
>
> http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026982/
>
> Roger
>
> On 10/22/2013
The changes in the security area look fine to me.
--Sean
On 10/22/2013 04:31 PM, roger riggs wrote:
Thanks for the comments, updated with Webrev with the suggestions.
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026982/
Roger
On 10/22/2013 2:53 PM, roger riggs wrote:
Please review
Thanks for the comments, updated with Webrev with the suggestions.
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026982/
Roger
On 10/22/2013 2:53 PM, roger riggs wrote:
Please review more javadoc cleanup to satisfy javadoc -Xlint.
The changes remove markup where it is invalid or unnec
Hi Mike,
On 10/22/2013 3:13 PM, Mike Duigou wrote:
Wow, that's a lot of nits!
Reviewed via patch:
- "{@code" is redundant. You could remove the
will do.
- This change should be reverted I think:
- * When mapping resource bundle names to
+ * When mapping resource bundle names to
javadoc c
Hi Roger,
On 10/22/2013 11:53 AM, roger riggs wrote:
Please review more javadoc cleanup to satisfy javadoc -Xlint.
The changes remove markup where it is invalid or unnecessary
in packages java. io, lang, net, nio, rmi, security, text, and util.
(this is a relatively low priority cleanup).
Webr
Hi Lance,
ok, I will add {@code}... since that's the current style. (Not used
everywhere yet).
Roger
On 10/22/2013 3:11 PM, Lance Andersen - Oracle wrote:
Overall, I think is this good.
I think in MessageDigest
--- old/src/share/classes/java/security/MessageDigest.java 2013-10-21
1
Wow, that's a lot of nits!
Reviewed via patch:
- "{@code" is redundant. You could remove the
- This change should be reverted I think:
- * When mapping resource bundle names to
+ * When mapping resource bundle names to
Mike
On Oct 22 2013, at 11:53 , roger riggs wrote:
> Please review mor
Overall, I think is this good.
I think in MessageDigest
--- old/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.734881244 -0400
+++ new/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.558891607 -0400
@@ -54,21 +54,21 @@
*
* Implementa
Please review more javadoc cleanup to satisfy javadoc -Xlint.
The changes remove markup where it is invalid or unnecessary
in packages java. io, lang, net, nio, rmi, security, text, and util.
(this is a relatively low priority cleanup).
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-
12 matches
Mail list logo
