Re: Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-19 Thread Jim Gish
Thanks, guys. I think I'll go with your suggested language David. I realize this might be somewhat unnecessary, but I'm trying to tighten up the javadoc in String as much as possible. I prefer to err on the side of completeness than leave doubts as to what's going on. As such, I don't

Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-18 Thread Jim Gish
Please review this minor usage note change for Bug 4722265: diff -r 8a454e92aaf1 src/share/classes/java/lang/AbstractStringBuilder.java --- a/src/share/classes/java/lang/AbstractStringBuilder.javaMon Sep 17 12:40:33 2012 +0200 +++ b/src/share/classes/java/lang/AbstractStringBuilder.java

Re: Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-18 Thread Chris Hegarty
Jim, I'm not all that sure that this is really such an issue. The methods that can reduce the capacity seem to be clearly specified. But others may have a stronger opinion, for or against, than me. Coming up with small concise wording for these type of issues is always difficult. I don't

Re: Please review: 4722265 (spec str) StringBuffer.ensureCapacity() should mention that capacity is mutable

2012-09-18 Thread David Holmes
I also think this is a non-issue - particularly from a report 10 years ago. I wouldn't waste time on it. You can't document every nuance of every method when used in conjunction with other methods. If you feel the need to complete this now then the shorter the better: Note that subsequent