Kumar Srinivasan wrote:
No the -XD is needed the Utils.java is dependent on sun.* apis,
which will not be accessible when compiling and testing with a built
SDK, which is required for Pack200 testing.
Sorry, I missed that (Utils.java isn't changed and so isn't in the webrev).
ok will yank it
On 11/4/2010 3:53 AM, Alan Bateman wrote:
Kumar Srinivasan wrote:
Thanks for all the reviews and suggestions!
the new version is at:
http://cr.openjdk.java.net/~ksrini/6985763/webrev.01
In this revision:
1. the input parameter is renamed to "in",
btw. we call out throwing of NPEs at the p
Kumar Srinivasan wrote:
Thanks for all the reviews and suggestions!
the new version is at:
http://cr.openjdk.java.net/~ksrini/6985763/webrev.01
In this revision:
1. the input parameter is renamed to "in",
btw. we call out throwing of NPEs at the package level documentation
http://down
Looks good.
- You may want to consider using getLocalizedMessage() rather than
getMessage(). If there is a localized version of the IllegalStateException
message then the result will be a stack dump that begins with the unlocalized
version of the message followed by a "Caused by" section which
Hi Kumar,
This looks okay to me. I prefer this form - only converting the
IllegalStateException - as well.
David
On 11/04/10 09:12, Kumar Srinivasan wrote:
Thanks for all the reviews and suggestions!
the new version is at:
http://cr.openjdk.java.net/~ksrini/6985763/webrev.01
In this revisi
Thanks for all the reviews and suggestions!
the new version is at:
http://cr.openjdk.java.net/~ksrini/6985763/webrev.01
In this revision:
1. the input parameter is renamed to "in",
btw. we call out throwing of NPEs at the package level documentation
http://download.oracle.com/javase/6/d
I will look into incorporating all the comments, watch out for the next
version.
Kumar
Kumar Srinivasan wrote:
Hi,
These are simple changes to the java.util.jar.pack:
* fixes JCK failures, specifically throwing unexpected exceptions
* minor fixes to the ClassFormatException
* added a
Kumar Srinivasan wrote:
Hi,
These are simple changes to the java.util.jar.pack:
* fixes JCK failures, specifically throwing unexpected exceptions
* minor fixes to the ClassFormatException
* added a new test to catch the JCK type failures up-front, which is
bulk of the code changes.
h
On 3/11/2010 8:04 AM, Mike Duigou wrote:
- In PackerImpl if the exception thrown is an IOException it is not
re-thrown. By not initializing inFiles this code path would have been
seen as "inFiles not initialized" at the inFiles.size() expression.
Also a minor nit in UnpackerImpl:
91 * @
- ClassReader.java: I think the change of the copyright date is incorrect. It
should be "2001, 2005, 2010" or "2001, 2005-2010".
- In PackerImpl if the exception thrown is an IOException it is not re-thrown.
By not initializing inFiles this code path would have been seen as "inFiles not
initial
On Nov 2, 2010, at 3:04 PM, Mike Duigou wrote:
> - ClassReader.java: I think the change of the copyright date is incorrect. It
> should be "2001, 2005, 2010" or "2001, 2005-2010".
Standard Oracle copyright format has just the first and last year, no ranges
and no other years. -- John
On Nov 2, 2010, at 2:10 PM, Kumar Srinivasan wrote:
> These are simple changes to the java.util.jar.pack:
> * fixes JCK failures, specifically throwing unexpected exceptions
> * minor fixes to the ClassFormatException
> * added a new test to catch the JCK type failures up-front, which is
>
Hi,
These are simple changes to the java.util.jar.pack:
* fixes JCK failures, specifically throwing unexpected exceptions
* minor fixes to the ClassFormatException
* added a new test to catch the JCK type failures up-front, which is
bulk of the code changes.
http://cr.openjdk.java.net
13 matches
Mail list logo
