Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-16 Thread David Holmes
On 17/12/2018 12:51 pm, dean.l...@oracle.com wrote: If we are adding JDK_EXPORT, does it make sense to add JDK_CALL as well? It should never be necessary. JNICALL is only needed to ensure caller and callee use the same calling convention. For JDK_EXPORT the caller and callee are part of the

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-16 Thread dean . long
If we are adding JDK_EXPORT, does it make sense to add JDK_CALL as well? dl On 12/16/18 4:57 PM, David Holmes wrote: Hi Magnus, Thanks for explaining how addition of JNIEXPORT may have started this problem. One follow up: This will also need a CSR request due to the change in linking

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-16 Thread David Holmes
Hi Magnus, Thanks for explaining how addition of JNIEXPORT may have started this problem. One follow up: This will also need a CSR request due to the change in linking behaviour. I'm not sure what you mean by this..? My entire intention here is that we should make no changes to documented

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-13 Thread Magnus Ihse Bursie
On 2018-12-12 13:17, David Holmes wrote: Okay I went away and did some homework ... Let me back up a bit and see if I have the evolution of this correctly. The native implementation of Java methods should be declared and defined with JNIEXPORT and JNICALL. JNIEXPORT controls the export

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-12 Thread David Holmes
Okay I went away and did some homework ... Let me back up a bit and see if I have the evolution of this correctly. The native implementation of Java methods should be declared and defined with JNIEXPORT and JNICALL. JNIEXPORT controls the export visibility so they can be linked. JNICALL

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-12 Thread Magnus Ihse Bursie
On 2018-12-11 23:47, David Holmes wrote: On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote: On 2018-12-11 00:23, David Holmes wrote: Hi Magnus, On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: I propose that we introduce a new define, available to all JDK native files (Hotspot

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-12 Thread Magnus Ihse Bursie
On 2018-12-12 09:40, David Holmes wrote: On 12/12/2018 5:44 pm, Volker Simonis wrote: On Tue, Dec 11, 2018 at 11:47 PM David Holmes wrote: On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote: On 2018-12-11 00:23, David Holmes wrote: Hi Magnus, On 10/12/2018 11:19 pm, Magnus Ihse Bursie

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-12 Thread David Holmes
On 12/12/2018 5:44 pm, Volker Simonis wrote: On Tue, Dec 11, 2018 at 11:47 PM David Holmes wrote: On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote: On 2018-12-11 00:23, David Holmes wrote: Hi Magnus, On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: I propose that we introduce a new

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-11 Thread Volker Simonis
On Tue, Dec 11, 2018 at 11:47 PM David Holmes wrote: > > On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote: > > > > > > On 2018-12-11 00:23, David Holmes wrote: > >> Hi Magnus, > >> > >> On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: > >>> I propose that we introduce a new define, available to

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-11 Thread David Holmes
On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote: On 2018-12-11 00:23, David Holmes wrote: Hi Magnus, On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-11 Thread Volker Simonis
On Tue, Dec 11, 2018 at 3:35 PM Magnus Ihse Bursie wrote: > > > > On 2018-12-11 00:23, David Holmes wrote: > > Hi Magnus, > > > > On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: > >> I propose that we introduce a new define, available to all JDK native > >> files (Hotspot included), called

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-11 Thread Magnus Ihse Bursie
On 2018-12-11 00:23, David Holmes wrote: Hi Magnus, On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this symbol will be very similar (as of now, in fact

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-10 Thread David Holmes
Hi Magnus, On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote: I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this symbol will be very similar (as of now, in fact identical) to JNIEXPORT; however, the semantics

Re: Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-10 Thread Erik Joelsson
Sounds good to me. /Erik On 2018-12-10 05:19, Magnus Ihse Bursie wrote: I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this symbol will be very similar (as of now, in fact identical) to JNIEXPORT; however,

Proposal: Use new JDK_EXPORT decorator instead of JNIEXPORT

2018-12-10 Thread Magnus Ihse Bursie
I propose that we introduce a new define, available to all JDK native files (Hotspot included), called JDK_EXPORT. The behavior of this symbol will be very similar (as of now, in fact identical) to JNIEXPORT; however, the semantics will not. Currently, we "mis-use" the JNIEXPORT define to