) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
Hi Goetz,
On 14/12/2016 9:46 PM, Lindenmaier, Goetz wrote:
object to the change to k_standard.c for the same reason.
Ok, I remove that too.
I had not realized this wa
eability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> Hi Goetz,
>
> On 14/12/2016 9:46 PM, Lindenmaier, Goetz wrote:
> >
> >> object to the ch
eability-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
On 14/12/2016 9:00 PM, Lindenmaier, Goetz wrote:
Hi,
You're right, I had removed the change to e_asin.c.
You only pointe
indenma...@sap.com>;
> daniel.daughe...@oracle.com; 'Dmitry Samersoff'
> <dmitry.samers...@oracle.com>; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR(M): 8170663: Fix m
<goetz.lindenma...@sap.com>;
daniel.daughe...@oracle.com; 'Dmitry Samersoff'
<dmitry.samers...@oracle.com>; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and s
eability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> On 14/12/2016 8:23 PM, Lindenmaier, Goetz wrote:
> > Hi David,
> >
> > I found "8169317
etz <goetz.lindenma...@sap.com>;
daniel.daughe...@oracle.com; 'Dmitry Samersoff'
<dmitry.samers...@oracle.com>; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicab
> >>
> >> David
> >> -----
> >>
> >>> Dan
> >>>
> >>>
> >>>
> >>>>
> >>>> David
> >>>> -
> >>>>
> >>>>>> The jvmpath -> jvm_newpath change was
om>; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
On 9/12/2016 7:31 AM, Daniel D. Daugherty wrote:
On 12/8/16 1:59 PM, David Holmes wrote:
nt on
> >>>> the strdup would have sufficed IMO.
> >>> Dmitry asked me to add it. But I think it's ok.
> >>>
> >>> Can I consider this reviewed now? I.e. could I push it once 8066474 is
> >>> promoted and Joe Darcy agreed?
> >>
maier, Goetz <goetz.lindenma...@sap.com>
> Cc: Java Core Libs <core-libs-dev@openjdk.java.net>
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> Hi Goetz,
>
> Please leave fdlibm asin alone as part of this change. The fdlibm
&
<goetz.lindenma...@sap.com>; 'Dmitry Samersoff'
> <dmitry.samers...@oracle.com>; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR(M): 8170663: Fix mino
ty-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and
servicabilty
coding.
Hi Goetz,
On 8/12/2016 1:26 AM, Lindenmaier, Goetz wrote:
Hi Dmitry,
yes, new_jvmpath is consistent with the other variables.
I also merged the
ap.com>; 'Dmitry Samersoff'
<dmitry.samers...@oracle.com>; Java Core Libs ; serviceability-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and
servicabilty
coding.
Hi Goetz,
On 8/12/2016 1:26 AM
ty-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
Hi Goetz,
On 8/12/2016 1:26 AM, Lindenmaier, Goetz wrote:
Hi Dmitry,
yes, new_jvmpath is consistent with the other variables.
I als
gt;; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> This changes fdlibm, which has historically been untouched. Don't commit
> wi
oetz <goetz.lindenma...@sap.com>; Java Core Libs
<core-libs-dev@openjdk.java.net>; serviceability-dev (serviceability-
d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
coding.
Goetz,
SDE.c:
You m
day, December 07, 2016 2:43 PM
> > To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Java Core Libs
> > <core-libs-dev@openjdk.java.net>; serviceability-dev (serviceability-
> > d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> > Subject: Re: RFR(M
@sap.com>; Java Core Libs
>> <core-libs-dev@openjdk.java.net>; serviceability-dev (serviceability-
>> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
>> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
>> coding.
>>
samers...@oracle.com]
> Sent: Wednesday, December 07, 2016 2:43 PM
> To: Lindenmaier, Goetz <goetz.lindenma...@sap.com>; Java Core Libs
> <core-libs-dev@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
>
Goetz,
SDE.c:
You might combine if at ll. 260 and 263 to one but it's just matter of test.
if (sti == baseStratumIndex || sti < 0) {
return; /* Java stratum - return unchanged */
}
> I'm not sure what you mean. I tried to fix it, but please
> double-check the new webrev.
if cnt is
; <dmitry.samers...@oracle.com>; Java Core Libs > d...@openjdk.java.net>; serviceability-dev (serviceability-
>> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
>> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
>> coding.
>>
try.samers...@oracle.com>; Java Core Libs d...@openjdk.java.net>; serviceability-dev (serviceability-
> d...@openjdk.java.net) <serviceability-...@openjdk.java.net>
> Subject: Re: RFR(M): 8170663: Fix minor issues in corelib and servicabilty
> coding.
>
> On 7/12/20
On 7/12/2016 6:37 PM, Lindenmaier, Goetz wrote:
Hi Dmitry,
thanks for looking at my change!
Updated webrev:
http://cr.openjdk.java.net/~goetz/wr16/8170663-corlib_s11y/webrev.02
* src/java.base/unix/native/libjli/java_md_solinux.c
Is this line correct?
519 jvmpath =
Hi Dmitry,
thanks for looking at my change!
Updated webrev:
http://cr.openjdk.java.net/~goetz/wr16/8170663-corlib_s11y/webrev.02
> * src/java.base/unix/native/libjli/java_md_solinux.c
> Is this line correct?
> 519 jvmpath = JLI_StringDup(jvmpath);
It seems pointless. Should I remove
Goetz,
For serviceability code, please see comments below:
* src/java.base/share/native/libjli/java.c
No comments
* src/java.base/unix/native/libjli/java_md_solinux.c
Is this line correct?
519 jvmpath = JLI_StringDup(jvmpath);
* src/jdk.jdwp.agent/share/native/libjdwp/SDE.c
It
26 matches
Mail list logo
