Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-09 Thread Peter Levart
Hi David, On 07/09/2018 09:33 AM, David Holmes wrote: On 9/07/2018 5:22 PM, Peter Levart wrote: Hi David, On 07/09/2018 03:37 AM, David Holmes wrote: Hi Peter, On 7/07/2018 2:10 AM, Peter Levart wrote: Hi, On 07/05/2018 01:01 AM, David Holmes wrote: I dispute "they will understand this

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-09 Thread David Holmes
On 9/07/2018 5:22 PM, Peter Levart wrote: Hi David, On 07/09/2018 03:37 AM, David Holmes wrote: Hi Peter, On 7/07/2018 2:10 AM, Peter Levart wrote: Hi, On 07/05/2018 01:01 AM, David Holmes wrote: I dispute "they will understand this might have happened in another thread". What if the

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-09 Thread Peter Levart
Hi David, On 07/09/2018 03:37 AM, David Holmes wrote: Hi Peter, On 7/07/2018 2:10 AM, Peter Levart wrote: Hi, On 07/05/2018 01:01 AM, David Holmes wrote: I dispute "they will understand this might have happened in another thread". What if the stack trace was like the following... Yes

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-08 Thread David Holmes
Hi Peter, On 7/07/2018 2:10 AM, Peter Levart wrote: Hi, On 07/05/2018 01:01 AM, David Holmes wrote: I dispute "they will understand this might have happened in another thread". What if the stack trace was like the following... Yes your suggestion makes it much clearer. But ... my whole

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-06 Thread Peter Levart
Hi, On 07/05/2018 01:01 AM, David Holmes wrote: I dispute "they will understand this might have happened in another thread". What if the stack trace was like the following... Before patch: 1st attempt [ForkJoinPool.commonPool-worker-3]: java.lang.ExceptionInInitializerError     at

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-04 Thread David Holmes
d...@openjdk.java.net runtime ; Java Core Libs Subject: Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors Hi Volker, This doesn't really address any of the concerns I had with the original proposal - it just moves the "field" from the Java side

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-04 Thread Peter Levart
Hi Volker, It occurred to me that getting rid of backtrace-s of cause(s)/suppressed exception(s) might not be enough to prevent ClassLoader leaks... On 07/04/2018 10:21 AM, Lindenmaier, Goetz wrote: dealing with backtrace and stackTrace. I have to wonder why nothing in Throwable clears the

RE: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-04 Thread Lindenmaier, Goetz
rom: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On > Behalf Of David Holmes > Sent: Sonntag, 1. Juli 2018 23:48 > To: Volker Simonis ; hotspot-runtime- > d...@openjdk.java.net runtime ; > Java Core Libs > Subject: Re: RFR(M): 8203826: Chain class initializat

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-07-01 Thread David Holmes
Hi Volker, This doesn't really address any of the concerns I had with the original proposal - it just moves the "field" from the Java side to the VM side. There is still a massive amount of Java code execution in relation to this - which itself may encounter secondary exceptions. It's very

Re: RFR(M): 8203826: Chain class initialization exceptions into later NoClassDefFoundErrors

2018-06-30 Thread Peter Levart
Hi Volker, I fully support this change, although I'm not qualified to review it as I'm not so acquainted with VM internals. The code looks reasonable to me though. This change will greatly help track down class initializiation bugs. I don't think that attaching a cause which is not directly