RE: RFR: 8234821: remove unused functions from libjli

2019-11-29 Thread Baesken, Matthias
; Subject: Re: RFR: 8234821: remove unused functions from libjli > > On 28/11/2019 12:02, Baesken, Matthias wrote: > > Thanks for the review . I'll adjust the COPYRIGHT . > > > > Will push this as XS in case of no objections. > > > I think this look okay. I ass

Re: RFR: 8234821: remove unused functions from libjli

2019-11-28 Thread Alan Bateman
On 28/11/2019 12:02, Baesken, Matthias wrote: Thanks for the review . I'll adjust the COPYRIGHT . Will push this as XS in case of no objections. I think this look okay. I assume you'll send a job through jdk-submit in case there are any residual launcher or installer code that also need to be

RE: RFR: 8234821: remove unused functions from libjli

2019-11-28 Thread Baesken, Matthias
k.java.net > Subject: RE: RFR: 8234821: remove unused functions from libjli > > Hi Matthias, > > overall this looks good to me. > > The only change to src/java.base/share/native/libjli/jli_util.c is the > copyrights, so I guess this should be omitted... > &g

RE: RFR: 8234821: remove unused functions from libjli

2019-11-28 Thread Langer, Christoph
Mittwoch, 27. November 2019 09:56 > To: core-libs-dev@openjdk.java.net > Subject: [CAUTION] RE: RFR: 8234821: remove unused functions from libjli > > Hello, I missed the reference from windows only code to JLI_MemRealloc , > new webrev : > > http://cr.openjdk.java.net/~mbaesken/web

RE: RFR: 8234821: remove unused functions from libjli

2019-11-27 Thread Baesken, Matthias
Hello, I missed the reference from windows only code to JLI_MemRealloc , new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8234821.1/ Best regards, Matthias Hello, please review this small change . It removed unneeded functions from libjli (shown by link-time-gc) . libjli cont